-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI deploy-DEV run in pull requests from forked repository #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing linting issue #2301 that is causing this to fail |
admiralAwkbar
approved these changes
Jan 6, 2022
lindluni
added a commit
that referenced
this pull request
Jan 10, 2022
)" This reverts commit aebd29e.
lindluni
added a commit
that referenced
this pull request
Jan 10, 2022
)" This reverts commit aebd29e. This breaks PRs for pull_requests from the repo itself. Will fix in a later commit
sarahc23
pushed a commit
to 23andMe/super-linter
that referenced
this pull request
May 6, 2022
…er#2300) Co-authored-by: Lukas Gravley <admiralawkbar@github.com>
sarahc23
pushed a commit
to 23andMe/super-linter
that referenced
this pull request
May 6, 2022
…per-linter#2300)" (super-linter#2319) This reverts commit aebd29e. This breaks PRs for pull_requests from the repo itself. Will fix in a later commit
sarahc23
pushed a commit
to 23andMe/super-linter
that referenced
this pull request
May 6, 2022
…er#2300) Co-authored-by: Lukas Gravley <admiralawkbar@github.com>
sarahc23
pushed a commit
to 23andMe/super-linter
that referenced
this pull request
May 6, 2022
…per-linter#2300)" (super-linter#2319) This reverts commit aebd29e. This breaks PRs for pull_requests from the repo itself. Will fix in a later commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
If we create pull requests from forked repository, CI
deploy-DEV
anddeploy-DEV-slim
do not run.Therefore, I add the trigger
pull_request
to CIdeploy-DEV
anddeploy-DEV-slim
in order to run CIs in pull requests from forked repository.Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance