shfmt files

[nemchik]

I ran:

docker run --rm -v ${PWD}:${PWD} mvdan/shfmt -s -i 2 -ci -sr -w ${PWD}/.automation/*.sh
docker run --rm -v ${PWD}:${PWD} mvdan/shfmt -s -i 2 -ci -sr -w ${PWD}/.vscode/*.sh
docker run --rm -v ${PWD}:${PWD} mvdan/shfmt -s -i 2 -ci -sr -w ${PWD}/lib/*.sh

(does not recurse through subfolders, so the intentionally bad shell files for test purposes are untouched)

This is just a code formatter. It can be used as a linter as well (I've mentioned it in some issue discussion). Most of the changes are whitespace changes. Generally all of the changes are meant to improve readability and ensure the shell (bash) does not incorrectly interpret anything.

If there are any specific questions feel free to comment inline.

I won't be too hurt if this doesn't merge. It took seconds to create this branch, and a valid reason for NOT merging it would be that this style of formatting would not be enforced in the future (unless it were to be mandated via pre-commit hooks or GHA checks). But it can still carry value as a one-off.

[admiralAwkbar]

I really like the cleanup of the code! It seems to be all spacing fixes and cleanup of some formatting. The only thing is just the de-quoting of some of the vars... I understand that you should quote the vars to prevent parameter expansion issues, but it's not complaining about some of them being unquoted...

[nemchik]

I really like the cleanup of the code! It seems to be all spacing fixes and cleanup of some formatting. The only thing is just the de-quoting of some of the vars... I understand that you should quote the vars to prevent parameter expansion issues, but it's not complaining about some of them being unquoted...

See https://github.com/github/super-linter/pull/351#discussion_r448993344

[nemchik]

P.S. I use https://marketplace.visualstudio.com/items?itemName=foxundermoon.shell-format and install shfmt from https://github.com/mvdan/sh either natively on linux or using https://scoop.sh/ on windows. I would use chocolatey but there is no package for shfmt in the chocolatey repositories.

[admiralAwkbar]

Dope