replace kubeval with kubeconform #3607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
requested review from
admiralAwkbar,
lindluni,
zkoppert,
nemchik,
Hanse00,
GaboFDC and
ferrarimarco
as code owners
ferrarimarco
requested changes
Dec 21, 2022
| # Kubeval Version | ||
| ARG KUBEVAL_VERSION='v0.16.1' | ||
| # Kubeconform Version | ||
| ARG KUBECONFORM_VERSION='v0.5.0' |
There was a problem hiding this comment.
Given that Kubeconform has a container image available, can you please refactor this PR to use that? By doing that, we can leverage Dependabot for updates. Thanks!
There was a problem hiding this comment.
is there any documentation specifying which is preferred? I personally would vote for binary though.
There was a problem hiding this comment.
Basically, if a container image is available, we try using that so that Dependabot takes care of updating that. As you can see, in the current implementation, the Kubeconform image would need to be manually updated.
|
Added in #3800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3496
Closes #2460
replacing kubeval with kubeconform as kubeval is no longer maintained.