Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify automation workflows #3689

Merged
merged 33 commits into from
Jan 5, 2023
Merged

Simplify automation workflows #3689

merged 33 commits into from
Jan 5, 2023

Conversation

lindluni
Copy link
Contributor

@lindluni lindluni commented Dec 23, 2022 •
edited
Loading

This PR is a full rework of our CICD practices.

  1. Splits the CI portions that run on Pull Request as a separate workflow from CD where we publish images on merge to main. This make it easier to understand what is happening when.
  2. Cleaned up the names of each step to make them visible by making them shorter to prevent being cutoff in the UI, but also to make them more descriptive of what the step was doing.
  3. Uses the larger-hosted runner which helps with the time it takes to build the image, but also with the number of times we encounter the anonymous IP rate limit throttles on GitHub due to using unauthenticated calls to GitHub.
  4. Simplified the Matrix strategy to only need variations that are required, reducing the number of inputs.
  5. Disabled the PSMissingModuleManifestField Powershell linting rule for our repo as it is erroneously assuming our PWSH linter templates are actual Powershell modules as we used poor naming schemes for the Powershell linter rules filename.

Signed-off-by: Brett Logan lindluni@github.com

@lindluni lindluni changed the title Simplify automation workflows [WIP]: Simplify automation workflows Dec 24, 2022
@lindluni lindluni changed the title [WIP]: Simplify automation workflows Simplify automation workflows Jan 4, 2023
@lindluni lindluni marked this pull request as ready for review January 4, 2023 00:50
@lindluni lindluni force-pushed the workflow branch 5 times, most recently from ee37bb8 to 8194128 Compare January 4, 2023 06:35
ferrarimarco
ferrarimarco requested changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits 😄

.github/linters/actionlint.yaml Show resolved Hide resolved
.github/workflows/cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/stack-linter.yml Outdated Show resolved Hide resolved
@lindluni lindluni force-pushed the workflow branch 3 times, most recently from 5fbad1e to 3318e16 Compare January 5, 2023 04:13
@lindluni
Simplify automation workflows
19e97af 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Remove old workflows
714b8eb 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Fix build args
bb4b8d3 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Fix image-id input
903f405 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Fix action.yml update
f48af15 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Fix action.yml update
e3d1399 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Remove action.yml update debugging
3cbecbb 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Add actionlint.yaml
0103765 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Remove stray slash
9a7e50c 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Remove stray git
eae0df3 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Update step name
3f95c7a 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Use canonical PSScriptAnalyzer setting file extension
cdd6dc7 
The PSScriptAnalyzer expects a text file, not a PowerShell extension
on the filename. The latest version of powershell now respects this
rule and breaks testing as the settings file doesn't meet the requirements
of the linter.

Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Fix workflow name
48b67d7 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Rename workflow file
d0bb671 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Update step name
4cecd5b 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Clean up matrix properties
f301cbf 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Create deployment workflow
16a58b5 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Add ModuleVersion to ARM template
caac9fb 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Clean up step names
813b32b 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Fix environment variable
774cee1 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Revert psd1 extension change and ignore PSMissingModuleManifestField
4286929 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Only trigger stack-linter push on main branch
49c0372 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Update release workflow
6e54a60 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Remove buildx setup
afa4b30 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Update workflow name
56bf9f9 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Fix step name
e458e71 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Use concurrency group for CD to limit wasteful runs
5c90026 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Add concurrency group to CI to reduce duplication
84918ee 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Fix concurrency group name
3b3a2a5 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Fix Dockerfile conflict
4ddb77e 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Address review comments
7fc479e 
Signed-off-by: Brett Logan <lindluni@github.com>
@lindluni
Add missing secrets
0a914cc 
Signed-off-by: Brett Logan <lindluni@github.com>
@ferrarimarco
Copy link
Collaborator

We might want to disable the Stack linter required check on the main branch protection rule.

@ferrarimarco
Copy link
Collaborator

(I don't have the right privileges to do that)

@lindluni lindluni merged commit de0d0f7 into main Jan 5, 2023
@lindluni lindluni deleted the workflow branch January 5, 2023 14:46
@ferrarimarco ferrarimarco added infrastructure related to project structure and maintenance automation related to helping the project operate more efficiently labels Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrarimarco ferrarimarco ferrarimarco approved these changes

@admiralAwkbar admiralAwkbar Awaiting requested review from admiralAwkbar

@zkoppert zkoppert Awaiting requested review from zkoppert zkoppert is a code owner

@nemchik nemchik Awaiting requested review from nemchik

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

@GaboFDC GaboFDC Awaiting requested review from GaboFDC

Assignees
No one assigned
Labels
automation related to helping the project operate more efficiently infrastructure related to project structure and maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lindluni @ferrarimarco