Add support for Azure Resource Manager (ARM) linting with [arm-ttk] #369
Conversation
krowlandson
requested review from
admiralAwkbar,
IAmHughes,
jwiebalk and
zkoppert
as code owners
|
Just to add, I'm not sure what tests you run in the background so please reach out if there's anything which needs fundamentally changing for this to pass all internal checks. |
|
Will investigate this: Successfully found binary for [arm-ttk] in system location: [/usr/bin/arm-ttk]
---------------------------
File:[/tmp/lint/.automation/test/arm/arm_bad_1.json]
- File:[arm_bad_1.json] failed test case with [arm-ttk] successfully
---------------------------
File:[/tmp/lint/.automation/test/arm/arm_good_1.json]
ERROR! Found errors in [arm-ttk] linter!
ERROR:[/action/lib/worker.sh: line 356: Import-Module: command not found]
ERROR: Linter CMD:[Import-Module /opt/microsoft/arm-ttk/arm-ttk/arm-ttk.psd1 ; $config = $(Import-PowerShellDataFile -Path /action/lib/.automation/.arm-ttk.psd1) ; Test-AzTemplate @config -TemplatePath /tmp/lint/.automation/test/arm/arm_good_1.json] |
|
Sorry, just addes some quality checks following the TestCodebase fix. That should be me done unless you have any further suggestions for updates or additions. I plan to add some more specific test cases (probably taken from arm-ttk/unit-tests itself) in the future but haven't had a chance to integrate yet so please review and merge if you're happy with the changes. |
|
@krowlandson That is some amazing work! thank you for all the hard work! |
That's great... thank you for picking this up for integration so quickly! Looking forward to making more use of this in our pipelines 😄 Happy to provide help if any bugs. |
Did you catch what was causing this? |
Azure Resource Manager (ARM) linting with [arm-ttk]
Hopefully you don't mind me dropping this in... I'm doing some work where I need to validate ARM templates. Rather than running a seperate linter, I've worked on integrating arm-ttk into Super-Linter.
I think I've covered off the important elements and maintained consistency with existing approaches / standards. I've also pulled in all latest updates and integrated these with my work too. Please feel free to pass feedback for updates as needed.
Hopefully the rest is fairly self-explanatory.