Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore dotfiles when running eslint #3791

Merged
merged 2 commits into from
Jan 7, 2023
Merged

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Jan 6, 2023

Fixes #3574

Proposed Changes

  1. Don't ignore dotfiles when running eslint, but ignore anything in the node_modules directory.
  2. Added a couple of test cases for the previous point.
  3. Remove the .eslintignore file from our repository to centralize the ignored files configuration in .eslintrc.yml.
  4. Remove .github/linters/.eslintrc.yml because we don't override any property vs the default (TEMPLATES/.eslintrc.yml), so we can use that one directly.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@ferrarimarco ferrarimarco added the enhancement New feature or request label Jan 6, 2023
Copy link

@muiriswoulfe muiriswoulfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this out!

TEMPLATES/.eslintrc.yml Show resolved Hide resolved
@ferrarimarco
Copy link
Collaborator Author

@muiriswoulfe No worries :)

As you can see from the build logs, dotfiles are now picked up.

@lindluni lindluni merged commit 9bcd243 into main Jan 7, 2023
@lindluni lindluni deleted the dont-ignore-eslint-dotfiles branch January 7, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files beginning with . excluded from JSON linting
3 participants