Fix Google Java Format tests and return code, and show output only if changed #3810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
google-java-format
exit with an error if there are formatting changes by setting the--set-exit-if-changed
. Without this flag, we cannot differentiate between correctly formatted files and incorrectly formatted ones becausegoogle-java-format
returns0
in both cases by default.google-java-format
output more concise by only outputting files that have a formatting not in line with the stype by setting the--dry-run
option. If we don't set this,google-java-format
outputs the whole formatted file in all cases.google-java-format
test cases to correctly expect successes and failures. We didn't notice the missing--set-exit-if-changed
because all the test cases were picked up in a way that they expected successes in all cases.Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance