Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves notice under h1 #4189

Merged
merged 1 commit into from
May 15, 2023
Merged

Moves notice under h1 #4189

merged 1 commit into from
May 15, 2023

Conversation

Hanse00
Copy link
Collaborator

@Hanse00 Hanse00 commented May 13, 2023

One of the linter rules run against this repo requires the README start with an h1. By inserting this notice above in #4152, the linter rule has been broken. This change fixes it.

Proposed Changes

  1. Bring org notice under the h1 of the README file

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

One of the linter rules run against this repo requires the README start with an h1.
By inserting this notice above, the linter rule has been broken.
@Hanse00 Hanse00 added the bug Something isn't working label May 13, 2023
@Hanse00
Copy link
Collaborator Author

Hanse00 commented May 13, 2023

Note: I expect the standard build to fail until #4188 is merged in as well.

@Hanse00 Hanse00 enabled auto-merge (squash) May 13, 2023 23:56
Copy link
Contributor

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Hanse00 Hanse00 disabled auto-merge May 15, 2023 16:12
@zkoppert zkoppert merged commit e048fe4 into main May 15, 2023
3 of 4 checks passed
@zkoppert zkoppert deleted the fix-readme-formatting branch May 15, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants