Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use calculated major version instead of hardcoded v5 #4441

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Use calculated major version instead of hardcoded v5 #4441

merged 2 commits into from
Jul 3, 2023

Conversation

zkoppert
Copy link
Contributor

@zkoppert zkoppert commented Jul 3, 2023 •
edited
Loading

fixes #4419

Proposed Changes

  1. Use calculated major version instead of hardcoded v5

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@zkoppert zkoppert self-assigned this Jul 3, 2023
@zkoppert zkoppert added the automation related to helping the project operate more efficiently label Jul 3, 2023
@zkoppert zkoppert mentioned this pull request Jul 3, 2023
Closed
Hanse00
Hanse00 previously approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@Hanse00 Hanse00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this!

@zkoppert
Copy link
Contributor Author

zkoppert commented Jul 3, 2023

.github/workflows/release.yml failed because it has trailing whitespace. How dare I! 😆 Fixing that now so it (hopefully) passes the lint.

@zkoppert zkoppert merged commit 1f93390 into main Jul 3, 2023
4 checks passed
@zkoppert zkoppert deleted the zkoppert-patch-1 branch July 3, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hanse00 Hanse00 Hanse00 left review comments

@admiralAwkbar admiralAwkbar Awaiting requested review from admiralAwkbar

@lindluni lindluni Awaiting requested review from lindluni

@nemchik nemchik Awaiting requested review from nemchik

@GaboFDC GaboFDC Awaiting requested review from GaboFDC

@ferrarimarco ferrarimarco Awaiting requested review from ferrarimarco ferrarimarco is a code owner

Assignees

@zkoppert zkoppert

Labels
automation related to helping the project operate more efficiently
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't hardcode major version in release builds
2 participants
@zkoppert @Hanse00