Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception for type-linting #4470

Merged
merged 4 commits into from
Sep 17, 2023
Merged

Add exception for type-linting #4470

merged 4 commits into from
Sep 17, 2023

Conversation

zkoppert
Copy link
Contributor

@zkoppert zkoppert commented Jul 11, 2023

since we are linting file by file to avoid running into https://typescript-eslint.io/linting/troubleshooting#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file

Fixes #4445

Proposed Changes

  1. Since we are linting file by file, don't use linting rules that require context outside a single file.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@zkoppert zkoppert self-assigned this Jul 11, 2023
@zkoppert zkoppert added the bug Something isn't working label Jul 11, 2023
@zkoppert zkoppert marked this pull request as ready for review August 10, 2023 21:50
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

If you're a maintainer, you can stop the bot to mark this issue as stale in the future by adding the O: backlog 🤖 label`.

@github-actions github-actions bot added the O: stale 🤖 Stale issue/pr label Sep 10, 2023
@ferrarimarco ferrarimarco added O: backlog 🤖 Backlog, stale ignores this label and removed O: stale 🤖 Stale issue/pr labels Sep 12, 2023
@ferrarimarco ferrarimarco added this pull request to the merge queue Sep 17, 2023
Merged via the queue into main with commit 102cb5d Sep 17, 2023
4 checks passed
@ferrarimarco ferrarimarco deleted the ts-trouble branch September 17, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript Standard linting broken in v5.0.0
2 participants