Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker image used by slim version of the action #4505

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

grahame-student
Copy link
Contributor

Fixes #4494

Update the docker image referenced in the slim metadata file to use the same version as the main version of the action.

Proposed Changes

  1. Uses the updated super-linter/super-linter repo
  2. Bumps the slim image version to 5.2.0 to align with the full-fat version of the action

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request (N/A)

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Uses the updated super-linter/super-linter repo
Bumps the slim image version to 5.2.0 to align with the full-fat version of the action
@grahame-student
Copy link
Contributor Author

Would it also be worth having a mechanism to either

  • Keep the two versions aligned automatically?
  • Detect when the two versions diverge?

@zvailanu98
Copy link


#################################
#################################

Super Linter GitHub Actions

#################################
#################################
name: Lint Code Base

#############################

Start the job on all push

#############################
on:
push:
branches-ignore: [master, main]
# Remove the line above to run when pushing to master
pull_request:
branches: [master, main]

###############

Set the Job

###############
jobs:
build:
# Name the Job
name: Lint Code Base
# Set the agent to run on
runs-on: ubuntu-latest

############################################
# Grant status permission for MULTI_STATUS #
############################################
permissions:
  contents: read
  packages: read
  statuses: write

##################
# Load all steps #
##################
steps:
  ##########################
  # Checkout the code base #
  ##########################
  - name: Checkout Code
    uses: actions/checkout@v3
    with:
      # Full git history is needed to get a proper
      # list of changed files within `super-linter`
      fetch-depth: 0

  ################################
  # Run Linter against code base #
  ################################
  - name: Lint Code Base
    uses: super-linter/super-linter@v5
    env:
      VALIDATE_ALL_CODEBASE: false
      DEFAULT_BRANCH: master
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@zvailanu98
Copy link

a89ffa0

@zkoppert zkoppert added the automation related to helping the project operate more efficiently label Aug 7, 2023
@zkoppert
Copy link
Contributor

zkoppert commented Aug 7, 2023

@grahame-student Yes, that would be really helpful. I would lean towards automation to keep the versions in sync.

@zkoppert zkoppert enabled auto-merge (squash) August 7, 2023 18:48
@zkoppert zkoppert merged commit 3a5ba0b into super-linter:main Aug 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation related to helping the project operate more efficiently
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is the slim image no longer being updated?
3 participants