Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake to Dockerfile dependencies #4524

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

smallstepman
Copy link
Contributor

@smallstepman smallstepman commented Aug 3, 2023

Rust's Clippy will fail to run if one of project's dependencies requires cmake. An example of such dependency would be:

Cargo.toml

[dependencies]
flate2 = { version = "1.0.11", default-features = false, features = ["zlib-ng"] }

because it depends on:

Cargo.lock

[[package]]
name = "libz-ng-sys"
version = "1.1.12"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "3dd9f43e75536a46ee0f92b758f6b63846e594e86638c61a9251338a65baea63"
dependencies = [
 "cmake",
 "libc",
]

example of failed workflow: https://github.com/dfinity/dfx-extensions/actions/runs/5754121209/job/15598769038#step:5:1893

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@zkoppert zkoppert added the dependencies Pull requests that update a dependency file label Aug 10, 2023
@zkoppert zkoppert merged commit be839d7 into super-linter:main Aug 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants