-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Babel preset for React package #4653
Add Babel preset for React package #4653
Conversation
The React preset for Babel is useful for automatically adding Babel plugins to understand JSX syntax.
@fdanielsen Thanks for submitting a pull request! I'm confused and need some help to determine what we are trying to accomplish here. This pull request currently adds a dependency but then I don't see any code that actually uses that dependency. Can you help me understand the goal of this pull request? |
Sorry for the confusion. I don't think there is any direct code in super-linter to update. But our ESLint config, and I would think quite a few others', depend implicitly on this preset. We use the |
That makes more sense. Can you resolve the branch conflicts and we can get this one merged through? |
Great, I've merged in latest from the main branch now and fixed conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks for the contribution!!
Thanks for the prompt review! Any idea when you'll make a new release so I can test this out in a GitHub action? |
I try to keep an every Friday release schedule but am also terrible at doing it consistently. So, i've just published a new release so you can give it a try anytime. https://github.com/super-linter/super-linter/releases/tag/v5.3.1 |
The React preset for Babel is useful for automatically adding Babel plugins to understand JSX syntax.
Proposed Changes
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance