Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds optional security linting for Terraform #473

Merged
merged 17 commits into from
Jul 24, 2020
Merged

Adds optional security linting for Terraform #473

merged 17 commits into from
Jul 24, 2020

Conversation

cesar-rodriguez
Copy link
Contributor

@cesar-rodriguez cesar-rodriguez commented Jul 24, 2020

Proposed Changes

  1. Adding optional security linting of terraform files
  2. This uses Terrascan with the VALIDATE_TERRAFORM_TERRASCAN environment variable
  3. The VALIDATE_TERRAFORM_TERRASCAN variable is set to "false" by default

Readiness Checklist

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@cesar-rodriguez cesar-rodriguez marked this pull request as ready for review July 24, 2020 05:04
@admiralAwkbar admiralAwkbar self-assigned this Jul 24, 2020
@admiralAwkbar admiralAwkbar added the enhancement New feature or request label Jul 24, 2020
@admiralAwkbar
Copy link
Collaborator

@cesar-rodriguez Really nice work!

I took the liberty to remove a dead groovy loop that was bad merged in...

Also, you had it default to false, but all other linters default to true, so I wanted to keep it on the same level and consistency in action. Hope that isn't a big issue?

Copy link
Collaborator

@admiralAwkbar admiralAwkbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So dope

@cesar-rodriguez
Copy link
Contributor Author

@cesar-rodriguez Really nice work!

I took the liberty to remove a dead groovy loop that was bad merged in...

Also, you had it default to false, but all other linters default to true, so I wanted to keep it on the same level and consistency in action. Hope that isn't a big issue?

Sounds good.

@admiralAwkbar admiralAwkbar merged commit c9eae48 into super-linter:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants