Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pip requirements files #4796

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Simplify pip requirements files #4796

merged 1 commit into from
Oct 27, 2023

Conversation

ferrarimarco
Copy link
Collaborator

Fixes #3727

Proposed Changes

  1. Remove transitive dependencies of each linter from pip requirements files. We now rely on each linter to install its own dependencies. This will reduce the number of dependency updates to take care of, and reduce the number of failing builds due to dependency conflicts. It may also make the image somewhat smaller because some of these transitive dependencies were dropped by their upstreams, and not needed anymore.
  2. Remove two dependency update scripts that we don't need anymore.
  3. Fix a couple of typos in a comment.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@ferrarimarco ferrarimarco added O: backlog 🤖 Backlog, stale ignores this label dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Oct 27, 2023
@ferrarimarco ferrarimarco self-assigned this Oct 27, 2023
Copy link
Contributor

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Thanks for taking this on!! 🎉

@zkoppert zkoppert added this pull request to the merge queue Oct 27, 2023
Merged via the queue into main with commit 9ee2eed Oct 27, 2023
3 checks passed
@zkoppert zkoppert deleted the clean-pip-reqs branch October 27, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file O: backlog 🤖 Backlog, stale ignores this label python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify dependency files
2 participants