Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the info target when running the test suite #4799

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Run the info target when running the test suite #4799

merged 1 commit into from
Oct 31, 2023

Conversation

ferrarimarco
Copy link
Collaborator

Proposed Changes

  1. Run the info target before running the test target to get useful info to compare with the baseline.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@ferrarimarco ferrarimarco added infrastructure related to project structure and maintenance automation related to helping the project operate more efficiently O: backlog 🤖 Backlog, stale ignores this label labels Oct 30, 2023
zkoppert
zkoppert approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this would break if docker isn't running but the test makefile target already requires docker daemon to be running so sounds good to me.

@ferrarimarco ferrarimarco added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit bb8ba1a Oct 31, 2023
3 checks passed
@ferrarimarco ferrarimarco deleted the make-info branch October 31, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert zkoppert approved these changes

@admiralAwkbar admiralAwkbar Awaiting requested review from admiralAwkbar

@lindluni lindluni Awaiting requested review from lindluni

@nemchik nemchik Awaiting requested review from nemchik

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

@GaboFDC GaboFDC Awaiting requested review from GaboFDC

Assignees
No one assigned
Labels
automation related to helping the project operate more efficiently infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ferrarimarco @zkoppert