-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log #486
Conversation
Looks good |
hey just checking in, Can you check off the boxes that you completed in the description. |
Done, and added one last task unless anyone looks through this sooner and finds something else that should be adjusted. I figure we may over time move around what is output as |
Ok, documentation is added. This should be ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Fixes #485
Proposed Changes
echo
calls) should use the log functionsLog Functions Added
fatal
will display a fatal message (red background, white text) AND willexit 1
. Always displayed regardless ofLOG_LEVEL
error
will display an error message (red text). Always displayed regardless ofLOG_LEVEL
warn
will display a warn message (yellow text). Always displayed regardless ofLOG_LEVEL
notice
will display a notice message (green text). Always displayed regardless ofLOG_LEVEL
info
will display an info message (blue text). Only displays if 'LOG_LEVELis set to
VERBOSE`debug
will display a debug message (blue text). Only displays if 'LOG_LEVELis set to
DEBUG`trace
will display a trace message (blue text). Only displays if 'LOG_LEVELis set to
TRACE`All messages (regardless of
LOG_LEVEL
are output to theLOG_FILE
Readiness Checklist
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance
Remaining Tasks
notice
calls withinfo
calls as needed