Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address pwsh install failure #4888

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Address pwsh install failure #4888

merged 3 commits into from
Nov 21, 2023

Conversation

zkoppert
Copy link
Contributor

@zkoppert zkoppert commented Nov 21, 2023

Fixes #4887

Proposed Changes

  1. Open an issue upstream for the missing latest alpine release assets
  2. Hard code latest version with alpine assets available

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@zkoppert zkoppert self-assigned this Nov 21, 2023
@zkoppert zkoppert added the bug Something isn't working label Nov 21, 2023
@zkoppert
Copy link
Contributor Author

Looks like we are no longer getting. a valid URL back from the GitHub Releases API. See https://github.com/super-linter/super-linter/actions/runs/6948319549/job/18904040786?pr=4888#step:6:3995

@zkoppert
Copy link
Contributor Author

Tested the code change locally:

zkoppert@zacherys-mbp ~ % gh api repos/powershell/powershell/releases/tags/v7.3.10 | jq --arg target "x64" -r '.assets | .[] | select(.name | contains("linux-alpine-" + $target)) | .url'
https://api.github.com/repos/PowerShell/PowerShell/releases/assets/135884336

@zkoppert
Copy link
Contributor Author

Running actions checks here since they dont seem to be kicking off normally: https://github.com/super-linter/super-linter/actions/runs/6948655973

@zkoppert
Copy link
Contributor Author

This fix works! https://github.com/super-linter/super-linter/actions/runs/6948655973/job/18905093098#step:6:4002

We have already received an update though that will be better than this version pinning. PowerShell/PowerShell#20746

I'll implement that now.... 🏃🏻

@zkoppert zkoppert merged commit b006bfd into main Nov 21, 2023
3 checks passed
@zkoppert zkoppert deleted the zkoppert-patch-1 branch November 21, 2023 21:59
@ferrarimarco
Copy link
Collaborator

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pwsh install failure causing new PR checks to fail
2 participants