Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically handle Java dependencies updates #4891

Merged
merged 5 commits into from Nov 30, 2023
Merged

Automatically handle Java dependencies updates #4891

merged 5 commits into from Nov 30, 2023

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Nov 23, 2023 •
edited

Related to #4893

Proposed Changes

  1. Move dependency definitions for google-java-format and checkstyle to Gradle files.
  2. Watch these Gradle files for updates with DependaBot
  3. Dynamically fetch dependency versions from these Gradle files.

I didn't update the versions of these dependencies so that we can see if DependaBot is going to propose PRs once this is merged.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@ferrarimarco ferrarimarco added infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label labels Nov 23, 2023
@ferrarimarco ferrarimarco self-assigned this Nov 23, 2023
@anantdamle
Copy link

Fixes #4893

zkoppert
zkoppert approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More automated dependencies we don't have to do manually!! Wohoo!!! Thanks for putting this together!

@ferrarimarco ferrarimarco added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit 3d4a312 Nov 30, 2023
4 checks passed
@ferrarimarco ferrarimarco deleted the automate-java-deps branch November 30, 2023 08:44
@ferrarimarco ferrarimarco mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert zkoppert approved these changes

@admiralAwkbar admiralAwkbar Awaiting requested review from admiralAwkbar

@lindluni lindluni Awaiting requested review from lindluni

@nemchik nemchik Awaiting requested review from nemchik

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

@GaboFDC GaboFDC Awaiting requested review from GaboFDC

Assignees

@ferrarimarco ferrarimarco

Labels
infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ferrarimarco @anantdamle @zkoppert