Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ts-standard configuration #4932

Merged
merged 2 commits into from Dec 2, 2023
Merged

Fix ts-standard configuration #4932

merged 2 commits into from Dec 2, 2023

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Dec 1, 2023

Fixes #4897
Fixes #3141
Fixes #3228

Proposed Changes

  1. Change the behavior of TYPESCRIPT_STANDARD_TSCONFIG_FILE to point to the full path of the TypeScript project file, instead of being relative to LINTER_RULES_PATH.
  2. Remove the logic to configure ts-standard, because it doesn't support changing its configuration, by design.
  3. Remove the TYPESCRIPT_STANDARD_FILE_NAME undocumented variable.
  4. Remove ${TYPESCRIPT_STANDARD_LINTER_RULES} from the ts-standard invocation because it's not supported by ts-standard.

Readiness Checklist

Author/Contributor

  • I included all the needed documentation for this change.
  • I provided the necessary tests.

Reviewing Maintainer

  • Label as breaking if this is a large, fundamental change.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label labels Dec 1, 2023
@ferrarimarco ferrarimarco self-assigned this Dec 1, 2023
@ferrarimarco
Copy link
Collaborator Author

/cc @massongit
/cc @dominicmeyer

@massongit
Copy link
Contributor

Thank you for the correction.

Copy link
Contributor

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🚀

@ferrarimarco ferrarimarco added this pull request to the merge queue Dec 2, 2023
Merged via the queue into main with commit a8150b4 Dec 2, 2023
3 checks passed
@ferrarimarco ferrarimarco deleted the fix-ts-standard branch December 2, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
3 participants