Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHP dependencies and GPG verification keys #4960

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Update PHP dependencies and GPG verification keys #4960

merged 4 commits into from
Dec 11, 2023

Conversation

zkoppert
Copy link
Contributor

@zkoppert zkoppert commented Dec 9, 2023 •
edited by ferrarimarco
Loading

Fixes #4959

Proposed Changes

  1. Update PHPCS repository link in README
  2. Update PHPStan from 1.3.3 to 1.10.48
  3. Update Psalm from 4.18.1 to 5.17.0
  4. Update PHPCS from 3.6.2 to 3.8.0
  5. Add GPG keys to verify the updates mentioned in this list.

Readiness Checklist

Author/Contributor

  • I included all the needed documentation for this change.
  • I provided the necessary tests.

Reviewing Maintainer

  • Label as breaking if this is a large, fundamental change.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

BEGIN_COMMIT_OVERRIDE
deps(php): bump PHPCS, PHPStan, Psalm (#4960)
END_COMMIT_OVERRIDE

@zkoppert zkoppert changed the title Update phive locations WIP ⚠️ Update phive locations Dec 9, 2023
@ferrarimarco ferrarimarco marked this pull request as draft December 9, 2023 09:59
@ferrarimarco ferrarimarco added bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label dependencies Pull requests that update a dependency file labels Dec 9, 2023
@ferrarimarco ferrarimarco changed the title WIP ⚠️ Update phive locations Update PHP dependencies and GPG verification keys Dec 9, 2023
@ferrarimarco ferrarimarco marked this pull request as ready for review December 9, 2023 16:38
@ferrarimarco
Copy link
Collaborator

@zkoppert I think it's ok now :)

@ferrarimarco ferrarimarco mentioned this pull request Dec 11, 2023
Merged
4 tasks
@ferrarimarco
Copy link
Collaborator

@zkoppert I think this needs your review and approval because I pushed a new commit.

This was referenced Dec 11, 2023
Merged
Merged
@zkoppert
Copy link
Contributor Author

@ferrarimarco I would approve however I am not allowed to approve a pr I started. Can you review?

@ferrarimarco
Copy link
Collaborator

Ah! I see. I'll merge it because I already reviewed. Thanks!

@ferrarimarco ferrarimarco merged commit 304ca18 into main Dec 11, 2023
3 checks passed
@ferrarimarco ferrarimarco deleted the zkoppert-patch-1 branch December 11, 2023 17:37
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrarimarco ferrarimarco ferrarimarco approved these changes

@admiralAwkbar admiralAwkbar Awaiting requested review from admiralAwkbar

@lindluni lindluni Awaiting requested review from lindluni

@nemchik nemchik Awaiting requested review from nemchik

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

@GaboFDC GaboFDC Awaiting requested review from GaboFDC

Assignees

@zkoppert zkoppert

Labels
bug Something isn't working dependencies Pull requests that update a dependency file O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

phive installation fails
2 participants
@zkoppert @ferrarimarco