-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify container image build #4962
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ferrarimarco
added
infrastructure
related to project structure and maintenance
O: backlog 🤖
Backlog, stale ignores this label
and removed
enhancement
New feature or request
labels
Dec 14, 2023
ferrarimarco
requested review from
admiralAwkbar,
lindluni,
zkoppert,
nemchik,
Hanse00 and
GaboFDC
as code owners
December 14, 2023 11:03
@zkoppert sorry if this turned to be quite big, but I kept finding new issues while fixing others :) |
zkoppert
reviewed
Dec 14, 2023
zkoppert
previously approved these changes
Dec 14, 2023
ferrarimarco
force-pushed
the
simplify-build
branch
from
December 15, 2023 10:10
68d7609
to
15fd6e4
Compare
@zkoppert thanks for your review! I fixed a few conflicts, so no major changes since you reviewed. Going ahead with this one :) |
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
infrastructure
related to project structure and maintenance
O: backlog 🤖
Backlog, stale ignores this label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
GLIBC_VERSION
once as a global argument inDockerfile
to reduce duplication.python:3.12.1-alpine3.19
. For some reason, dependabot was failing with a 403 when analyzing this dependency.hadolint
version instead oflatest
to make the build more reproducible.base_image
build step entirely. This stage was largely redundant because we copied everything we installed toslim
anyway. This saves up some build time, and makes the Dockerfile simpler.Dockerfile
.Dockerfile
to avoid invalidating the cache when they change.Dockerfile
build instructions earlier so we can better use the build cache.terrascan
andchktexrc
initialization frominstall-ktlint.sh
toDockerfile
because they don't have anything to do withktlint
.glibc-compat
multiple times in different script, and consolidate the logic to do this in ainstall-glibc.sh
script.install-xxxxx.sh
).phive.xml
to install dependencies instead of listing them when invoking phive.phive.xml
to install the same dependencies that we were installing explicitly from the command line. Note thatphive.xml
was already in/dependencies
, but unused and outdated.gitleaks
,prettier
,renovate-config-validator
,textlint
,ts-standard
.Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large, fundamental change.automation
,bug
,documentation
,enhancement
,infrastructure
.BEGIN_COMMIT_OVERRIDE
build: simplify container image build
END_COMMIT_OVERRIDE