Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install clang-format from OS package repo #5071

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Install clang-format from OS package repo #5071

merged 1 commit into from
Jan 1, 2024

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Dec 27, 2023 •
edited

Related to #4986

Proposed Changes

  • Build and install clang-format instead of pulling it from a (potentially) unmaintained repository.

Readiness Checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • If this is a breaking change, write upgrade instructions in the upgrade guide.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added O: backlog 🤖 Backlog, stale ignores this label dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Dec 27, 2023
@ferrarimarco ferrarimarco self-assigned this Dec 27, 2023
@ferrarimarco ferrarimarco changed the title build: install clang-format from OS package repo Install clang-format from OS package repo Dec 27, 2023
@ferrarimarco ferrarimarco mentioned this pull request Dec 27, 2023
Open
27 tasks
@ferrarimarco ferrarimarco marked this pull request as draft December 30, 2023 16:49
@ferrarimarco ferrarimarco marked this pull request as ready for review December 30, 2023 22:03
@ferrarimarco
build: install clang-format from OS package repo
c981de2 
Build and install clang-format instead of pulling it from a (potentially)
unmaintained repository
@ferrarimarco ferrarimarco merged commit 19e39e2 into main Jan 1, 2024
7 checks passed
@ferrarimarco ferrarimarco deleted the clang-format branch January 1, 2024 10:40
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert Awaiting requested review from zkoppert zkoppert is a code owner

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

Assignees

@ferrarimarco ferrarimarco

Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ferrarimarco