Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce container image size #5072

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Reduce container image size #5072

merged 1 commit into from
Dec 29, 2023

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Dec 27, 2023

Proposed Changes

  • Remove build-time dependencies
  • Remove cached NPM packages
  • Remove cached PyPi packages
  • Remove dependency descriptors. These still count against the total space, although it's a few KBs
  • Install rust-clippy and rust-fmt using the OS package manager instead of maintaining our own installation script
  • Add tests for build time dependencies that are not supposed to be installed

Results:

standard: from 8.01GB to 5.92GB
slim: from 5.63GB to 3.97GB

Readiness Checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • If this is a breaking change, write upgrade instructions in the upgrade guide.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label labels Dec 27, 2023
@ferrarimarco ferrarimarco self-assigned this Dec 27, 2023
@ferrarimarco ferrarimarco force-pushed the reduce-size branch 19 times, most recently from d64aa75 to 3a374fa Compare December 28, 2023 15:41
@ferrarimarco ferrarimarco force-pushed the reduce-size branch 3 times, most recently from ece8805 to 5b5cf26 Compare December 28, 2023 20:57
@ferrarimarco ferrarimarco changed the title build: reduce container image size Reduce container image size Dec 28, 2023
- Remove build-time dependencies
- Remove cached NPM packages
- Remove cached PyPi packages
- Remove dependency descriptors. These still count against the total space,
  although it's a few KBs
- Install rust-clippy and rust-fmt using the OS package manager instead of
  maintaining our own installation script
- Add tests for build time dependencies that are not supposed to be installed
@ferrarimarco ferrarimarco marked this pull request as ready for review December 29, 2023 15:33
@ferrarimarco ferrarimarco merged commit 1ca3ebc into main Dec 29, 2023
7 checks passed
@ferrarimarco ferrarimarco deleted the reduce-size branch December 29, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant