Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take package-lock into account in dev-container #5278

Merged
merged 1 commit into from
Feb 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,73 +9,84 @@ updates:
directory: "/"
schedule:
interval: weekly
open-pull-requests-limit: 100

- package-ecosystem: github-actions
commit-message:
prefix: "deps(github-actions)"
directory: "/"
schedule:
interval: "weekly"
open-pull-requests-limit: 100

- package-ecosystem: "npm"
commit-message:
prefix: "deps(npm)"
directory: "/dependencies"
schedule:
interval: "weekly"
open-pull-requests-limit: 100

- package-ecosystem: "bundler"
commit-message:
prefix: "deps(bundler)"
directory: "/dependencies"
schedule:
interval: "weekly"
open-pull-requests-limit: 100

- package-ecosystem: "docker"
commit-message:
prefix: "deps(docker)"
directory: "/"
schedule:
interval: "weekly"
open-pull-requests-limit: 100

- package-ecosystem: "pip"
commit-message:
prefix: "deps(python)"
directory: "/dependencies/python/"
schedule:
interval: "weekly"
open-pull-requests-limit: 100

- package-ecosystem: "gradle"
commit-message:
prefix: "deps(java)"
directory: "/dependencies/checkstyle"
schedule:
interval: "weekly"
open-pull-requests-limit: 100

- package-ecosystem: "gradle"
commit-message:
prefix: "deps(java)"
directory: "/dependencies/google-java-format"
schedule:
interval: "weekly"
open-pull-requests-limit: 100

- package-ecosystem: "gradle"
commit-message:
prefix: "deps(java)"
directory: "/dependencies/ktlint"
schedule:
interval: "weekly"
open-pull-requests-limit: 100

- package-ecosystem: "docker"
commit-message:
prefix: "deps(dev-docker)"
directory: "/dev-dependencies"
schedule:
interval: "weekly"
open-pull-requests-limit: 100

- package-ecosystem: "npm"
commit-message:
prefix: "deps(dev-npm)"
directory: "/dev-dependencies"
schedule:
interval: "weekly"
open-pull-requests-limit: 100
14 changes: 7 additions & 7 deletions dev-dependencies/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@ RUN apt-get update \
jq \
&& rm -rf /var/lib/apt/lists/*

WORKDIR /app
ENV APP_DIR=/app
WORKDIR "${APP_DIR}"

COPY package.json ./
COPY package.json package-lock.json ./

ENV NPM_PACKAGES_FILE_PATH="npm-packages.txt"
RUN npm ci \
&& rm -rf ~/.npm

RUN jq '.dependencies | to_entries[] | select(.key | startswith("@commitlint/")) | .key + "@" + .value' package.json >> "${NPM_PACKAGES_FILE_PATH}" \
&& jq '.dependencies | to_entries[] | select(.key | startswith("release-please")) | .key + "@" + .value' package.json >> "${NPM_PACKAGES_FILE_PATH}" \
&& xargs npm install -g < "${NPM_PACKAGES_FILE_PATH}" \
&& rm package.json "${NPM_PACKAGES_FILE_PATH}"
ENV NODE_PATH="${APP_DIR}/node_modules"
ENV PATH="${NODE_PATH}/.bin:${PATH}"

# Split this from the previous RUN instruction so we can cache the costly installation step
# hadolint ignore=DL3059
Expand Down