Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a shadowing setting in .golangci.yml #5654

Merged
merged 1 commit into from
May 16, 2024

Conversation

massongit
Copy link
Contributor

@massongit massongit commented May 16, 2024

Proposed changes

https://github.com/super-linter/super-linter/actions/runs/9095084838/job/24997762122

  level=warning msg=\"[config_reader] The configuration option `linters.govet.check-shadowing` is deprecated. Please enable `shadow` instead, if you are not using `enable-all`.\"

To resolve the above warning in go modules, I change check-shadowing in .golangci.yaml to enable shadowing.

Fix #5605

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@massongit massongit changed the title fix: Fix a shadowing setting in .golangci.yml fix: fix a shadowing setting in .golangci.yml May 16, 2024
@ferrarimarco ferrarimarco self-assigned this May 16, 2024
@ferrarimarco ferrarimarco added enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label labels May 16, 2024
Copy link
Collaborator

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! A small thing to address.

.github/linters/.golangci.yml Show resolved Hide resolved
@massongit massongit marked this pull request as ready for review May 16, 2024 14:12
Copy link
Contributor

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ferrarimarco ferrarimarco changed the title fix: fix a shadowing setting in .golangci.yml Fix a shadowing setting in .golangci.yml May 16, 2024
@ferrarimarco ferrarimarco added this pull request to the merge queue May 16, 2024
Merged via the queue into super-linter:main with commit 03b4aa0 May 16, 2024
48 checks passed
@ferrarimarco ferrarimarco added this to the 6.5.1 milestone May 16, 2024
@massongit massongit deleted the fix_shadowing_setting branch May 16, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Golang linter configuration to avoid the deprecated linters.govet.check-shadowing option
3 participants