Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate JavaScript and TypeScript language selection config variables #5679

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ferrarimarco
Copy link
Collaborator

Proposed changes

  • Remove JAVASCRIPT_DEFAULT_STYLE and TYPESCRIPT_DEFAULT_STYLE configuration variables because they create a confusing corner case that Super-linter already handles with its core logic that's in place to enable and disable linters.
  • Document VALIDATE_JAVASCRIPT_PRETTIER and VALIDATE_TYPESCRIPT_PRETTIER because they were missing from the README.

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added enhancement New feature or request breaking big changes, potentially causes failure O: backlog 🤖 Backlog, stale ignores this label labels May 24, 2024
@ferrarimarco ferrarimarco self-assigned this May 24, 2024
@ferrarimarco ferrarimarco changed the title feat!: deprecate ts and js language config vars Deprecate JavaScript and TypeScript language selection config variables May 24, 2024
@ferrarimarco ferrarimarco added this to the 7.0.0 milestone May 24, 2024
@ferrarimarco ferrarimarco marked this pull request as draft May 24, 2024 16:01
- Remove JAVASCRIPT_DEFAULT_STYLE and TYPESCRIPT_DEFAULT_STYLE
  configuration variables because they create a confusing corner case that
  Super-linter already handles with its core logic that's in place to
  enable and disable linters.
- Document VALIDATE_JAVASCRIPT_PRETTIER and VALIDATE_TYPESCRIPT_PRETTIER
  because they were missing from the README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking big changes, potentially causes failure enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant