Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError if value is null #1

Merged
merged 2 commits into from
Nov 6, 2018
Merged

Fix TypeError if value is null #1

merged 2 commits into from
Nov 6, 2018

Conversation

davist11
Copy link
Contributor

@davist11 davist11 commented Nov 1, 2018

This was a site updating from Craft 2 to Craft 3, and I was getting the following error:

TypeError: Argument 1 passed to craft\helpers\Json::decodeIfJson() must be of the type string, null given, called in /Users/tdavis/sites/viget/vendor/superbig/craft-vzaddress/src/fields/VzAddressField.php on line 86 and defined in /Users/tdavis/sites/viget/vendor/craftcms/cms/src/helpers/Json.php:30
Stack trace:
#0 /Users/tdavis/sites/viget/vendor/superbig/craft-vzaddress/src/fields/VzAddressField.php(86): craft\helpers\Json::decodeIfJson(NULL)
#1 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/base/Element.php(1936): superbig\vzaddress\fields\VzAddressField->normalizeValue(NULL, Object(craft\elements\User))
#2 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/base/Element.php(1612): craft\base\Element->normalizeFieldValue('address')
#3 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Extension/Core.php(1619): craft\base\Element->getFieldValue('address')
#4 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/helpers/Template.php(73): twig_get_attribute(Object(craft\web\twig\Environment), Object(Twig_Source), Object(craft\elements\User), 'getFieldValue', Array, 'method', false, false)
#5 /Users/tdavis/sites/viget/storage/runtime/compiled_templates/41/4184e7a84031c6affc496f5bb2a38198b8c348bff32e66dd953611803f2efe82.php(30): craft\helpers\Template::attribute(Object(craft\web\twig\Environment), Object(Twig_Source), Object(craft\elements\User), 'getFieldValue', Array, 'method')
#6 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(390): __TwigTemplate_5161fcd023f81b72b8c9849a99b259c977410554a3f734e095d068582e7d3700->doDisplay(Array, Array)
#7 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/twig/Template.php(49): Twig_Template->displayWithErrorHandling(Array, Array)
#8 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(367): craft\web\twig\Template->displayWithErrorHandling(Array, Array)
#9 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/twig/Template.php(31): Twig_Template->display(Array, Array)
#10 /Users/tdavis/sites/viget/storage/runtime/compiled_templates/be/bed1413c693faae52fbf84ca222eaa6fe0ad54ca697ace0605017d613fca2835.php(47): craft\web\twig\Template->display(Array)
#11 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(390): __TwigTemplate_44726c02b25df5efa4c5fca990e22101b25405af76ba7b864a936664de08bdd0->doDisplay(Array, Array)
#12 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/twig/Template.php(49): Twig_Template->displayWithErrorHandling(Array, Array)
#13 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(367): craft\web\twig\Template->displayWithErrorHandling(Array, Array)
#14 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/twig/Template.php(31): Twig_Template->display(Array, Array)
#15 /Users/tdavis/sites/viget/storage/runtime/compiled_templates/bb/bb1d20f4bad6f5be4c1592435dfc8b486c1577ac2726923a407eeb2d5051c7d4.php(268): craft\web\twig\Template->display(Array)
#16 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(189): __TwigTemplate_b19a87e90a21cd03a3056f31c73adada639785be5f438ce2f558ead07839d866->block_content(Array, Array)
#17 /Users/tdavis/sites/viget/storage/runtime/compiled_templates/a1/a13c57439be900f2528ac805b6f2b4520b60c50f41e9483a41981981f2200641.php(639): Twig_Template->displayBlock('content', Array, Array)
#18 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(189): __TwigTemplate_453996916711653199c35b6440dcfd5d14767c324f2f7bd3fd0da22409005f74->block_main(Array, Array)
#19 /Users/tdavis/sites/viget/storage/runtime/compiled_templates/a1/a13c57439be900f2528ac805b6f2b4520b60c50f41e9483a41981981f2200641.php(536): Twig_Template->displayBlock('main', Array, Array)
#20 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(189): __TwigTemplate_453996916711653199c35b6440dcfd5d14767c324f2f7bd3fd0da22409005f74->block_body(Array, Array)
#21 /Users/tdavis/sites/viget/storage/runtime/compiled_templates/28/2811b6efe2351e7a5665aeaa2a86694b313e36fda271916dfba78f47c83d6b12.php(60): Twig_Template->displayBlock('body', Array, Array)
#22 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(390): __TwigTemplate_85b4b79540a4a74c5cabba2dfa73dcef451a7a3004f1d338fc6625538cac2606->doDisplay(Array, Array)
#23 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/twig/Template.php(49): Twig_Template->displayWithErrorHandling(Array, Array)
#24 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(367): craft\web\twig\Template->displayWithErrorHandling(Array, Array)
#25 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/twig/Template.php(31): Twig_Template->display(Array, Array)
#26 /Users/tdavis/sites/viget/storage/runtime/compiled_templates/8b/8bb1950450e5c332ea4e9d5398e527b15235fece508babf86336f4d74fbe25dd.php(40): craft\web\twig\Template->display(Array, Array)
#27 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(390): __TwigTemplate_0e80729af85ef541d92c8af436d3075a838f05d3215f6ab4cf8ee2179813bf8d->doDisplay(Array, Array)
#28 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/twig/Template.php(49): Twig_Template->displayWithErrorHandling(Array, Array)
#29 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(367): craft\web\twig\Template->displayWithErrorHandling(Array, Array)
#30 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/twig/Template.php(31): Twig_Template->display(Array, Array)
#31 /Users/tdavis/sites/viget/storage/runtime/compiled_templates/a1/a13c57439be900f2528ac805b6f2b4520b60c50f41e9483a41981981f2200641.php(94): craft\web\twig\Template->display(Array, Array)
#32 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(390): __TwigTemplate_453996916711653199c35b6440dcfd5d14767c324f2f7bd3fd0da22409005f74->doDisplay(Array, Array)
#33 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/twig/Template.php(49): Twig_Template->displayWithErrorHandling(Array, Array)
#34 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(367): craft\web\twig\Template->displayWithErrorHandling(Array, Array)
#35 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/twig/Template.php(31): Twig_Template->display(Array, Array)
#36 /Users/tdavis/sites/viget/storage/runtime/compiled_templates/bb/bb1d20f4bad6f5be4c1592435dfc8b486c1577ac2726923a407eeb2d5051c7d4.php(86): craft\web\twig\Template->display(Array, Array)
#37 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(390): __TwigTemplate_b19a87e90a21cd03a3056f31c73adada639785be5f438ce2f558ead07839d866->doDisplay(Array, Array)
#38 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/twig/Template.php(49): Twig_Template->displayWithErrorHandling(Array, Array)
#39 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(367): craft\web\twig\Template->displayWithErrorHandling(Array, Array)
#40 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/twig/Template.php(31): Twig_Template->display(Array, Array)
#41 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Template.php(375): craft\web\twig\Template->display(Array)
#42 /Users/tdavis/sites/viget/vendor/twig/twig/lib/Twig/Environment.php(289): Twig_Template->render(Array)
#43 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/View.php(331): Twig_Environment->render('users/_edit', Array)
#44 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/View.php(378): craft\web\View->renderTemplate('users/_edit', Array)
#45 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/Controller.php(156): craft\web\View->renderPageTemplate('users/_edit', Array)
#46 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/controllers/UsersController.php(851): craft\web\Controller->renderTemplate('users/_edit', Array)
#47 [internal function]: craft\controllers\UsersController->actionEditUser(NULL, Object(craft\elements\User))
#48 /Users/tdavis/sites/viget/vendor/yiisoft/yii2/base/InlineAction.php(57): call_user_func_array(Array, Array)
#49 /Users/tdavis/sites/viget/vendor/yiisoft/yii2/base/Controller.php(157): yii\base\InlineAction->runWithParams(Array)
#50 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/Controller.php(104): yii\base\Controller->runAction('edit-user', Array)
#51 /Users/tdavis/sites/viget/vendor/yiisoft/yii2/base/Module.php(528): craft\web\Controller->runAction('edit-user', Array)
#52 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/Application.php(282): yii\base\Module->runAction('users/edit-user', Array)
#53 /Users/tdavis/sites/viget/vendor/yiisoft/yii2/web/Application.php(103): craft\web\Application->runAction('users/edit-user', Array)
#54 /Users/tdavis/sites/viget/vendor/craftcms/cms/src/web/Application.php(271): yii\web\Application->handleRequest(Object(craft\web\Request))
#55 /Users/tdavis/sites/viget/vendor/yiisoft/yii2/base/Application.php(386): craft\web\Application->handleRequest(Object(craft\web\Request))
#56 /Users/tdavis/sites/viget/public/index.php(21): yii\base\Application->run()
#57 {main}

@davist11
Copy link
Contributor Author

davist11 commented Nov 1, 2018

Actually, it may make sense to test if (is_string($value)) { instead since upon saving a user with an empty address field, an array was passed as the value

@sjelfull
Copy link
Member

sjelfull commented Nov 1, 2018

Yeah, thats probably a good idea.

@sjelfull sjelfull merged commit 312026c into superbigco:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davist11 @sjelfull