Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imported types issue #14

Closed
lakeshadow0 opened this issue Jun 19, 2021 · 2 comments
Closed

Imported types issue #14

lakeshadow0 opened this issue Jun 19, 2021 · 2 comments

Comments

@lakeshadow0
Copy link
Contributor

lakeshadow0 commented Jun 19, 2021 •
edited
Loading

Importing this package appears to have a problem in Typescript related to references for fs-extra types, which are not installed with the package.

declare const _default: typeof Fs & { // _default is any here, removing typeof Fs fixes this

Installing @types/fs-extra directly into the package (within my node_modules) fixes this. I would assume, then, that moving the types packages from devDependencies to dependencies would fix this permanently.
@marcuspoehls
Copy link
Member

Makes sense. Too bad the typings aren't resolved properly.

@lakeshadow0 Do you want to submit a pull request?

@lakeshadow0 lakeshadow0 mentioned this issue Jun 19, 2021
Merged
@marcuspoehls
Copy link
Member

@lakeshadow0 I’ve tagged 3.0.1 and published it to NPM. Thank you for your help with this issue! I really appreciate it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcuspoehls @lakeshadow0