-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added onProgress function and made some code refactors #34
Conversation
@Azrideus Thank you for the pull request. I can't merge it in this state. Please don't change the code styling in all files. You even changed linting rules to ensure your style. Can you please refine this PR to only include the changes for the onProgress handler without reformatting everything. You can also open a new pull request if it's to much to revert all other changes. With all the noise it's hard to review the actual changes. |
sorry it was my first ever PR , I should have know that |
Thank you 😊 Question: why can't you use the "process" method to show a progress bar? Do you want an explicit "onPostProcess" method to be sure the item was processed, either successful or with a failure? Basically a combination of "process" and "onError"? |
@Azrideus Hey, are you still in need of this feature? Can you make some time available to proceed on this pull request? |
@Azrideus Closing this PR here. Please feel free to re-open the merge request |
tests are included
sorry for the formatting changes but my IDE is enforcing this code style ( semi , indent ... )