Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmake and update sc #12

Merged
merged 8 commits into from
Sep 28, 2020

Conversation

dyfer
Copy link
Member

@dyfer dyfer commented Sep 25, 2020

I've updated SC sources and made changes to CMake to make SuperColliderAU build. Fixes #4, and #7, supersedes #8.

Aside from CMake updates, I made one change to the source, that fixed the error from auval:

Test MIDI
ERROR: -4 IN CALL MusicDeviceMIDIEvent

auval now passes, but only for no more than two runs of the plugin (-r 2). I'd like to file this as a separate issue later.

@dyfer dyfer marked this pull request as draft September 27, 2020 01:20
SuperColliderAU fails validation when run 3+ consecutive times (auval -r parameter); this is a workaround for the CI to pass temporarily, the root cause needs to be investigated
@dyfer dyfer force-pushed the topic/fix-cmake-and-update-sc branch from 6d654b1 to 2776f9e Compare September 27, 2020 01:39
@dyfer dyfer marked this pull request as ready for review September 27, 2020 02:09
@dyfer dyfer requested a review from g-roma September 27, 2020 02:09
@g-roma
Copy link
Member

g-roma commented Sep 27, 2020

Thanks for the fixes! I am now on an up to date OS which should make it easier for me to maintain SCAU.
Building and running is working for me on Catalina + Reaper with these changes at the moment. However I am seeing a segmentation fault in auval at the end, wich seems to point to something trickier. Are you not seeing it?
I'd be inclined to merge this regardless, as the update is long due, but this seems something that will need fixing as well.

@dyfer
Copy link
Member Author

dyfer commented Sep 27, 2020

Thanks @g-roma !
Yes, I was seeing segfault in auval, but only when -r parameter was 3 and up, that's why I temporarily lowered it.
For me it seemed to happen on the third start of the plugin somewhere after this line (thanks for leaving the debug printing in!) I'd treat it as a separate issue, unless you have an idea why it is happening, then I'd be happy to include a fix for it.

Copy link
Member

@g-roma g-roma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although it crashes at auval exit even with one go in my machine at the moment (working on a fix). Seems to work in AU host anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with CMake errors
2 participants