Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VBAP: Fix stairstepping during modulation #183

Merged
merged 1 commit into from Feb 2, 2018

Conversation

nhthn
Copy link

@nhthn nhthn commented Feb 2, 2018

this fixes #122 and replaces #123. i'm kicking myself because i delayed on this an entire year and only just now realized how simple the bug was.

the problem was a failure to increment the channel gains by the slopes in the nova-simd version of the code.

~array = VBAPSpeakerArray(2, [-30, 30, 0, -110, 110]);
~buf = ~array.loadToBuffer;
{ VBAP.ar(5, DC.ar(1), ~buf.bufnum, Line.kr(0, 360, 0.05), 1.0, 0.0) }.plot(0.05);

before:

vbap_before

after:

vbap_after

This commit fixes control-rate stairstepping when modulating the panning
arguments of VBAP when sc3-plugins is compiled with nova-simd.
Copy link
Contributor

@muellmusik muellmusik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, Nathan

@muellmusik
Copy link
Contributor

I'll combine with the VBAP 1.0.3.2 stuff etc. when I have time later. A bit bigger job...

@muellmusik muellmusik merged commit 9307b41 into supercollider:master Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VBAP panning arguments are strictly control rate and not interpolated
2 participants