Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview of color settings #386

Closed
lijon opened this issue Aug 18, 2012 · 4 comments
Closed

Preview of color settings #386

lijon opened this issue Aug 18, 2012 · 4 comments
Assignees
Milestone

Comments

@lijon
Copy link
Member

lijon commented Aug 18, 2012

When changing color settings and syntax color settings, it would be nice if the preview displayed at the bottom of the dialog did update with the changed colors.

@jleben
Copy link
Member

jleben commented Aug 18, 2012

The reason why this has not been done yet is that the current settings infrastructure doesn't support this, without sever refactoring.

Instead, I think it would be acceptable if there is an Apply button, which would apply all the settings without closing the dialog. This way one could previe color settings in the currently open document behind the settings dialog.

@jleben
Copy link
Member

jleben commented Aug 18, 2012

There's now an Apply button.

However, it might look weird that the font updates immediately, while the rest of the settings needs an "apply" to show in the preview. Actually, I would just remove the preview editor, but we need some code to see the current font choice on.
Opinions?

@ghost ghost assigned jleben Aug 27, 2012
@jleben
Copy link
Member

jleben commented Aug 30, 2012

There's now an Apply button. However, it might look weird that the font updates immediately, while the rest of the settings needs an "apply" to show in the preview. Actually, I would just remove the preview editor, but we need some code to see the current font choice on.

I've now completely removed the code editor from the editor configuration panel - also because that conflicted with code editor development for the purpose of split views.

I propose:

  1. to show the currently selected font with a simple one-line text
  2. to implement colors preview by applying the colors to text and background of items in the color selection list

@jleben
Copy link
Member

jleben commented Sep 3, 2012

Font and color configuration panels are now merged into one.
Both font and color preview is provided in the panel.

@jleben jleben closed this as completed Sep 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants