[SDESK-7156] Allow FeedingServices to provide request kwards for association downloading #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ciation downloading This is used by AP Media API to provide x-api-key header, among others
petrjasek
approved these changes
Apr 10, 2024
|
@petrjasek I have updated the implementation to use the feeding service like you suggested. Can you have another look for me please? |
petrjasek
approved these changes
Apr 11, 2024
marwoodandrew
approved these changes
Apr 12, 2024
MarkLark86
added a commit
to MarkLark86/superdesk-core
that referenced
this pull request
Apr 17, 2024
…ciation downloading (superdesk#2555) * [SDESK-7156] Allow FeedingServices to provide request kwards for association downloading This is used by AP Media API to provide x-api-key header, among others * fix: don't duplicate timeout arg to requests.get * Use request sessions and feeding_services to download media * Add comment to new config * Move get_request_kwargs from FeedingService to HTTPFeedingServiceBase * fix tests * Create util function to download from service or directly * fix circular imports
MarkLark86
added a commit
to MarkLark86/superdesk-core
that referenced
this pull request
Apr 17, 2024
…ciation downloading (superdesk#2555) * [SDESK-7156] Allow FeedingServices to provide request kwards for association downloading This is used by AP Media API to provide x-api-key header, among others * fix: don't duplicate timeout arg to requests.get * Use request sessions and feeding_services to download media * Add comment to new config * Move get_request_kwargs from FeedingService to HTTPFeedingServiceBase * fix tests * Create util function to download from service or directly * fix circular imports
MarkLark86
added a commit
to MarkLark86/superdesk-core
that referenced
this pull request
Apr 17, 2024
…ciation downloading (superdesk#2555) * [SDESK-7156] Allow FeedingServices to provide request kwards for association downloading This is used by AP Media API to provide x-api-key header, among others * fix: don't duplicate timeout arg to requests.get * Use request sessions and feeding_services to download media * Add comment to new config * Move get_request_kwargs from FeedingService to HTTPFeedingServiceBase * fix tests * Create util function to download from service or directly * fix circular imports fix: add Union import back in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used by AP Media API to provide x-api-key header, among others.
Also adds a new config
AP_MEDIA_API_VERIFY_SSL, which defaults to True. This is to help prevent MITM style attacks, but can be turned off by env. variable if SSL verification fails for some reason.