[SDESK-4026] Extend the Coverage concept to include iterations/updates to the original text coverage item #1162
Conversation
nrvikas
force-pushed
the
SDESK-4026
branch
2 times, most recently
from
4948061
to
7c3d69c
Compare
| ids.append(doc[config.ID_FIELD]) | ||
| items.append(item) | ||
| # Delete all delivery records for this assignment | ||
| get_resource_service('delivery').delete_action(lookup={'assignment_id': assignment[config.ID_FIELD]}) |
There was a problem hiding this comment.
When performing Unlink as Update action, won't this remove the delivery records for ALL items?
Should this be removing the delivery records using the items array instead?
There was a problem hiding this comment.
Yup, good catch, will update.
| # To support 'unlink as update' we need to link only that update. Not the entire chain | ||
| if actioned_item and actioned_item.get('rewrite_of'): | ||
| items = production.find({ | ||
| 'family_id': actioned_item.get('family_id'), |
There was a problem hiding this comment.
You will have to use the event_id here.
See lines for code:
https://github.com/superdesk/superdesk-core/blob/master/apps/archive/archive_rewrite.py#L107
https://github.com/superdesk/superdesk-core/blob/master/apps/archive/archive_rewrite.py#L153
https://github.com/superdesk/superdesk-core/blob/master/apps/archive/archive_rewrite.py#L292
https://github.com/superdesk/superdesk-client-core/blob/master/scripts/apps/archive/services/FamilyService.ts#L98
Original logic was based on find_one i.e. find by _id but now it different field. We have to use elastic index over here for event_id for archive and published endpoints. If the item is corrected/killed you will get more docs for single item_id. There is also rewrite_sequence field not sure if you need it to order deliveries.
| ]} | ||
| """ | ||
| When we enqueue published | ||
| When we get "/publish_queue" |
There was a problem hiding this comment.
As this is critical change, can we have end-to-end behave test which includes publishing of planning item using json planning formatter. (
see feature https://github.com/superdesk/superdesk-planning/blob/master/server/features/assignments_planning_publish.feature#L610
see step https://github.com/superdesk/superdesk-planning/blob/master/server/features/assignments_planning_publish.feature#L953
)
In the step you can assert the deliveries as well.
nrvikas
force-pushed
the
SDESK-4026
branch
2 times, most recently
from
e7a0aec
to
0f05bd8
Compare
…s to the original text coverage item added test cases added test cases added more test cases added test cases review changes test case fix review changes
No description provided.