feat(monitoring): SD-3123 Added fetch as panel on monitoring view #1135
Conversation
pavlovicnemanja
force-pushed
the
fetchAs
branch
from
9a90991
to
544b7e2
Compare
|
👍 |
| @@ -1431,6 +1431,8 @@ | |||
| }, | |||
| templateUrl: 'scripts/superdesk-authoring/views/send-item.html', | |||
| link: function sendItemLink(scope, elem, attrs) { | |||
| var parentScope = scope.$parent.$parent; | |||
There was a problem hiding this comment.
If I understand correctly, this grandparent scope is only referenced to obtain a reference to the monitoring controller used by the MonitoringViewDirective? If so, this pattern should be avoided, because it is fragile and sensitive to changes in the scope hierarchy.
The right way to do it is to declare that this directive depends on the parent MonitoringViewDirective (require: '^sdMonitoringView'), and then the monitoring controller will be passed to the link() function as its 4th argument:
function sendItemLink(scope, elem, attrs, ctrl) {
// ctrl === MonitoringController
There was a problem hiding this comment.
Yeah, I know, and in first way I do it like this. But (always some but), this directive is also used for sending item on another desk in authoring view. As there is no sdMonitoringView directive found by require in authoring screen, it throws error.
This way was my alternative.
There was a problem hiding this comment.
Hm... so how does the monitoring controller end up in the parent scope then, what places it there? Would it be possible to somehow reference that thing and obtain the controller reference from it?
@petrjasek @amagdas Are there any other good alternatives to obtaining the controller from the grandparent scope?
There was a problem hiding this comment.
Monitoring Controller is accessible with require on monitoring page. But it is not accessible on authoring page. So, as this two pages use same directive for sending item, on monitoring view works fine, but on authoring it throws an error. Because of that I added
if (parentScope.monitoring) { .
There was a problem hiding this comment.
Yeah, that's clear and perfectly fine... I'm just wondering if there exists a better way, that's all :)
There was a problem hiding this comment.
seems like it's only setting some css classes - you can use superdeskFlags service for that:
superdeskFlags.flags.fetching = !!item;
it will add fetching class to #main-container
There was a problem hiding this comment.
Oh, great :) ... I didn't saw this service :)
pavlovicnemanja
force-pushed
the
fetchAs
branch
from
544b7e2
to
dc7d7ec
Compare
| @@ -8,7 +8,7 @@ <h3 translate ng-show="mode === 'archive'">Duplicate</h3> | |||
| <div class="content"> | |||
| <div class="publish-pane-box"> | |||
| <div sd-toggle-box data-title="{{ 'Destination' | translate }}" data-open="true" | |||
| ng-if="mode === 'ingest' || (mode === 'authoring' && $root.isActionAllowed(item, 'move') && itemActions.send)"> | |||
| ng-if="mode === 'ingest' || mode === 'monitoring' || (mode === 'authoring' && $root.isActionAllowed(item, 'move') && itemActions.send)"> | |||
There was a problem hiding this comment.
Please extract long conditionals in the controller with a proper function name.
|
👍 |
pavlovicnemanja
force-pushed
the
fetchAs
branch
7 times, most recently
from
f898855
to
a4e4ead
Compare
pavlovicnemanja
force-pushed
the
fetchAs
branch
3 times, most recently
from
79339e1
to
a4e4ead
Compare
pavlovicnemanja
force-pushed
the
fetchAs
branch
2 times, most recently
from
3a7aafc
to
4a7899b
Compare
…, responsive behavior of send to panel
pavlovicnemanja
force-pushed
the
fetchAs
branch
from
4a7899b
to
2a24e97
Compare
|
👍 |
|
👍 |
feat(monitoring): SD-3123 Added fetch as panel on monitoring view
SD-3123