fix(monitoring): refresh monitoring on content changes #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| user = flask.g.get('user', {}) | ||
| push_notification( | ||
| 'content:update', | ||
| user=str(user.get('_id', '')), |
There was a problem hiding this comment.
can we use common.py.get_user() here?
There was a problem hiding this comment.
yep I just didn't want to import from archive here, so I will move the func here and import it into archive
There was a problem hiding this comment.
actually I will move it into apps.auth, imo it should be there
|
👍 |
petrjasek
force-pushed
the
fix-monitoring-refresh
branch
from
9ab4766
to
ec69a3c
Compare
|
👍 |
1 similar comment
|
👍 |
petrjasek
force-pushed
the
fix-monitoring-refresh
branch
from
ec69a3c
to
e336d93
Compare
|
👍 Rebase needed |
petrjasek
force-pushed
the
fix-monitoring-refresh
branch
from
e336d93
to
633584c
Compare
there is single event `content:update` with info about item, desk and stage which client can use to figure out what to update in monitoring. SD-3204 SD-3213
petrjasek
force-pushed
the
fix-monitoring-refresh
branch
from
633584c
to
4ebc858
Compare
amagdas
added a commit
that referenced
this pull request
Sep 21, 2015
fix(monitoring): refresh monitoring on content changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is single event
content:updatewith info about item, deskand stage which client can use to figure out what to update in monitoring.
SD-3204 SD-3213