fix(templates): fix template auto creation #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| item = {key: value for key, value in template.items() if key in metadata_schema} | ||
| item['template'] = item.pop('_id') | ||
| item['state'] = SCHEDULED_ITEM_STATE |
There was a problem hiding this comment.
Can we use constants for state, archive? Also, SCHEDULED_ITEM_STATE is defined in item.py.CONTENT_STATE
There was a problem hiding this comment.
right updated it. it shouldn't be scheduled state after all, but probably submitted - it's a new item on a desk that needs some work, not scheduled for publishing.
which was failing after first run, because it was using id from template for item. now this field is removed. SD-2099
|
👍 |
1 similar comment
|
👍 |
amagdas
added a commit
that referenced
this pull request
Sep 18, 2015
fix(templates): fix template auto creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which was failing after first run, because it was using id from
template for item. now this field is removed.
SD-2099