Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query syntax highlighting #6

Closed
superfell opened this issue Jun 5, 2012 · 4 comments · Fixed by #115
Closed

query syntax highlighting #6

superfell opened this issue Jun 5, 2012 · 4 comments · Fixed by #115
Labels

Comments

@superfell
Copy link
Owner

is more broken than right at this point, doesn't handle any of the soql-r or aggregate query constructs correctly.

@texastoland
Copy link

Have you considered a dependency for highlighting based on a grammar?

@superfell
Copy link
Owner Author

It should be using the grammar, not sure exactly what you mean by having a dependency for it.

@texastoland
Copy link

A third party library? What I saw in code looked like parsing from scratch. Maybe I missed it.

@superfell
Copy link
Owner Author

Correct, right now its doing parsing by hand, its not using any library or real grammar. The fix should include using the published grammar (and possibly a library).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants