Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] MacroForwarder postCheck hook #1886

Open
1 of 2 tasks
d10r opened this issue Mar 11, 2024 · 1 comment · May be fixed by #1903
Open
1 of 2 tasks

[ETHEREUM-CONTRACTS] MacroForwarder postCheck hook #1886

d10r opened this issue Mar 11, 2024 · 1 comment · May be fixed by #1903
Assignees
@d10r
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Type: Enhancement New feature or request

Comments

@d10r
Copy link
Collaborator

d10r commented Mar 11, 2024 •
edited
Loading

What & Why

After execution, the MacroForwarder shall invoked a hook postCheck().
This allows user macros to verify the state post execution and allow them to revert the transaction if they don't like (sloppy language here) the outcome.

AC

  • extended interface
  • test coverage
@d10r d10r added Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps labels Mar 11, 2024
@d10r d10r self-assigned this Mar 11, 2024
@hellwolf hellwolf added Type: Enhancement New feature or request and removed Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps labels Mar 11, 2024
@d10r d10r linked a pull request Mar 21, 2024 that will close this issue
Draft
@d10r d10r linked a pull request Mar 21, 2024 that will close this issue
[ETHEREUM-CONTRACTS] User Macro: added postCheck and recommendation for getParams #1903
Draft
@d10r
Copy link
Collaborator Author

d10r commented Mar 25, 2024

this currently lacks a good use / test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d10r d10r

Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@hellwolf @d10r