Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUBGRAPH] superTokenLogicCreatedEvents missing recent events #1912

Open
d10r opened this issue Mar 25, 2024 · 0 comments
Open

[SUBGRAPH] superTokenLogicCreatedEvents missing recent events #1912

d10r opened this issue Mar 25, 2024 · 0 comments
Assignees
Labels
Project: SUBGRAPH Superfluid protocol subgraph Type: Bug Something isn't working

Comments

@d10r
Copy link
Collaborator

d10r commented Mar 25, 2024

The script for updating Super Tokens queries superTokenLogicCreatedEvents in order to get a list of previous canonical logic contracts, see https://github.com/superfluid-finance/protocol-monorepo/blob/dev/packages/ethereum-contracts/ops-scripts/gov-upgrade-super-token-logic.js#L166

However this query returns incomplete data, it doesn't include recent deployments.

Example:
On optimism-mainnet, the latest canonical logic contract is 0x78743a68d52c9D6CCF3fF4558f3af510592E3C2D, see factory.

The SG query

query MyQuery {
  superTokenLogicCreatedEvents(orderDirection: desc, orderBy: timestamp) {
    id
    tokenLogic
  }
}

returns 0x882703dc8239e2ba167e06ce1fcf654e17a0bd06 as the most recent logic contract, which was deployed a year ago.

Without having checked, I guess the breakage may be related to switching to Custom Errors or to the restructuring of the SuperTokenFactory (canonical logic now being deployed in a dedicated tx by the script).

@d10r d10r added Project: SUBGRAPH Superfluid protocol subgraph Type: Bug Something isn't working labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: SUBGRAPH Superfluid protocol subgraph Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants