Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token minimum deposit + versions on protocol page #192

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

Mikkoun
Copy link
Contributor

@Mikkoun Mikkoun commented Oct 5, 2023

No description provided.

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
superfluid-console ✅ Ready (Inspect) Visit Preview Oct 5, 2023 0:32am

@0xdavinchee 0xdavinchee linked an issue Oct 5, 2023 that may be closed by this pull request
getFramework,
} from "@superfluid-finance/sdk-redux";

export const adhocRpcEndpoints = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the endpoint here is a redux toolkit terminology.

It can be easily confused with the endpoint of rpc gateway we often talk about in other context

@currents-bot
Copy link

currents-bot bot commented Oct 5, 2023

Cypress Tests tests failed after 20m 59s

🟢 60 · 🔴 1 · ⚪️ 0 · 🟣 1

View Run Details

Run Details

  • Project: Console

  • Groups: 1

  • Framework: Cypress

  • Run Status: Failed

  • Commit: 458b4f1

  • Spec files: 9

  • Overall tests: 61

  • Duration: 20m 59s

  • Parallelization: 1

Failed Spec Files

Spec File Failures
cypress/e2e/AccountPage.feature 1


This message was posted automatically by currents.dev | Integration Settings

@Mikkoun Mikkoun changed the title Token minimum deposit Token minimum deposit + versions on protocol page Oct 5, 2023
@0xdavinchee 0xdavinchee linked an issue Oct 5, 2023 that may be closed by this pull request
@hellwolf
Copy link
Contributor

hellwolf commented Oct 6, 2023

  1. flaky test; should not be a blocker.

  2. how it looks like:

image

image

  1. there are two networks haven't setup the deployment marker in resolver properly yet:
  • mainnet
  • zkevm testnet

^-- to be addressed separately later.

@hellwolf hellwolf merged commit f46fa37 into master Oct 6, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CONSOLE] show deployed protocol version [CONSOLE] show minimum deposit on token detail page
4 participants