added ENS resolver hooks, display results in the console (Ready for review) #105

Seroxdesign · 2022-07-04T17:09:01Z

Progress

Added two functions in the hooks folder. one resolves ENS to address and one resolves address to ENS

Remaining work

What's left:

Adding checks for search terms to ensure we call the right method
Adding a debounce to minimise spam to RPC
Showing results under search bar and on the account view page

vercel · 2022-07-04T17:09:06Z

@Seroxdesign is attempting to deploy a commit to the Superfluid Finance Team on Vercel.

A member of the Team first needs to authorize it.

Seroxdesign · 2022-07-04T17:10:16Z

ready for review

kasparkallas · 2022-07-05T12:08:52Z

Glad to see interest in contributing to the Console!

Some comments on how to solve this story:

We use RTK-Query to handle cache'ing and some request debounce'ing. Ethers' JsonRpcBatchProvider & FallbackProvider are used for further throttling & robustness.
We implemented a solution for the upcoming Dashboard and would like to re-use it in the Console. If the solution is not good then we'd like to know why. I put the snippets of the code in another ENS pull request: feat(console): add ens domains #88 (comment)
Effectively this bounty can be grabbed by just following these snippets.

Seroxdesign · 2022-07-05T12:13:41Z

Got it! Thank you Kasper

Seroxdesign · 2022-07-06T18:21:09Z

Still reading through all the snippets, and deciding how to fit them in. Expecting results by July 9th.

Seroxdesign · 2022-07-07T17:25:57Z

@kasparkallas @vmichalik @sunnyjaycer

Ready for review

vercel · 2022-07-12T09:52:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
superfluid-console	✅ Ready (Inspect)	Visit Preview	Aug 19, 2022 at 11:50AM (UTC)

kasparkallas

Did a quick tour and seems to work overall! 👍

Couple of comments:

doesn't show spinner when still fetching ENS
when on an account page and then going to another account's page then previous avatar is shownfor a short period of time (use RTK-query's .currentData over .data or set a key for the page [use address as key for example])
when both ENS and address book name are specified then the behaviour is weird with both showing and the address not showing
UI is a bit messy and doesn't follow https://mui.com/material-ui/

src/components/AddressBook.tsx

src/hooks/useAddressENS.tsx

src/pages/[_network]/accounts/[_id].tsx

src/redux/slices/addressBook.slice.ts

src/redux/store.ts

package.json

Seroxdesign · 2022-07-12T19:44:10Z

I believe most problems have been resolved, although I might need to figure out how to display addressBook name and ENS name

Seroxdesign · 2022-07-12T23:51:17Z

Did a quick tour and seems to work overall! 👍

Couple of comments:

* doesn't show spinner when still fetching ENS

* when on an account page and then going to another account's page then previous avatar is shownfor a short period of time (use RTK-query's `.currentData` over `.data` or set a _key_ for the page [use address as key for example])

* when both ENS and address book name are specified then the behavior is weird with both showing and the address not showing

* UI is a bit messy and doesn't follow https://mui.com/material-ui/

Switched to using currentData
Added conditionals to avoid rendering both address book name and ens name at the same time
Slightly improved UI on account page
Spinner isn't loading immediately because it takes a second to resolve ENS name to address for search

@kasparkallas Let me know if anything else needs work

Seroxdesign · 2022-07-13T10:48:10Z

So seems like there's an issue I am not handling right, I don't know what the best way to check name before I resolve to address

vmichalik

looks good to me!

elvijsTDL · 2022-07-18T18:30:35Z

The non-ens address in at the top of the page is alligned a little bit off now and it is smaller, here it is now

And here is the before

@vmichalik Should we also include showing the ENS names in the tables and using them in filters in this ticket?

elvijsTDL

Was on a slower network and the loading spinner doesn't show up when the ENS lookup is happening, actually thought the ENS lookup didn't work on Brave and Firefox because of that, could we please have one while the lookup is still happening , here is a video:

Screen.Recording.2022-07-18.at.21.40.42.mov

Also address book entries now show the input string too instead of just the result:

Seroxdesign · 2022-07-18T19:18:22Z

I can push a fix for these tomorrow morning, thanks for taking the time to review

Seroxdesign · 2022-07-20T11:14:38Z

The non-ens address in at the top of the page is alligned a little bit off now and it is smaller, here it is now

And here is the before

@vmichalik Should we also include showing the ENS names in the tables and using them in filters in this ticket?

I changed the size of the text to comply with the ENS frontend standard,

An example of how this is relevant, I wanted the ENS to be bigger than the address, although this can be changed back to the original style

Seroxdesign · 2022-07-20T11:17:53Z

Was on a slower network and the loading spinner doesn't show up when the ENS lookup is happening, actually thought the ENS lookup didn't work on Brave and Firefox because of that, could we please have one while the lookup is still happening , here is a video:
Screen.Recording.2022-07-18.at.21.40.42.mov

Also address book entries now show the input string too instead of just the result:

The text is a simple fix, I will remove showing the text on top of the address and instead only showed related addresses on ENS search.

As for the spinner, I tried fixing this yesterday but I am still trying to figure out the best way to do this without changing how the spinner renders. I will try again today and if I can't find a solution I will request support

…arching for an address in addressbook

Seroxdesign · 2022-07-20T12:29:59Z

Before:

After:

What's left:

[] Figuring out how to show spinner correctly.

Seroxdesign · 2022-07-23T22:11:30Z

@elvijsTDL @kasparkallas I am having trouble with the spinner task, I would appreciate any pointer or advice,

Seroxdesign · 2022-07-26T14:24:11Z

Was on a slower network and the loading spinner doesn't show up when the ENS lookup is happening, actually thought the ENS lookup didn't work on Brave and Firefox because of that, could we please have one while the lookup is still happening , here is a video:
Screen.Recording.2022-07-18.at.21.40.42.mov

Also address book entries now show the input string too instead of just the result:

Fixed using isFetching on ensQuery

vmichalik · 2022-07-27T09:51:54Z

@Seroxdesign, we really appreciate your efforts- you took to the task quickly, were responsive to feedback and suggestions and kept making tweaks to improve, so I'm more than happy to see this bounty paid out.

With Dashboard V2 still under such active development we likely won't have time to do a Console release containing this feature for a few weeks. However, we hope you enjoy the bounty payout, learnt more about ENS and the SDK-Redux and stick around for future bounties too🥇

Will DM you on Discord for next steps

elvijsTDL · 2022-08-19T07:52:58Z

LGTM 👍

* rename to clarify intent * be more explicit with types * remove unneccessary try-catches

kasparkallas

When there's an address book entry then ENS name is not displayed anywhere. Not sure if I like it... The ENS name should still be visible somewhere but let's handle that in the next iteration -- would like to get this merged. :)

added ENS resolver hooks, display results in the console

fc48e5d

Seroxdesign changed the title ~~added ENS resolver hooks, display results in the console~~ added ENS resolver hooks, display results in the console (WORK IN PROGRESS) Jul 4, 2022

Seroxdesign changed the title ~~added ENS resolver hooks, display results in the console (WORK IN PROGRESS)~~ added ENS resolver hooks, display results in the console (WIP) Jul 4, 2022

Seroxdesign added 2 commits July 6, 2022 16:56

added slices, added search both ways

cfcde2c

integrated ENS with an ENSresolver API slice

a337578

Seroxdesign changed the title ~~added ENS resolver hooks, display results in the console (WIP)~~ added ENS resolver hooks, display results in the console (Ready for review) Jul 7, 2022

Seroxdesign added 4 commits July 9, 2022 14:59

added other ens endings

d38dd57

changed conditional check for resolvename to check for a period vs .eth

3199364

fixed some issues with search not working

9e1631d

added conditional logic to avoid rendering name before load

8af495c

vercel bot deployed to Preview July 12, 2022 09:56 View deployment

kasparkallas reviewed Jul 12, 2022

View reviewed changes

Seroxdesign added 2 commits July 12, 2022 15:36

made adjustments

07f3c11

removed blockies

7e99c1f

fixed UI in page

d4c7fda

Seroxdesign changed the title ~~added ENS resolver hooks, display results in the console (Ready for review)~~ added ENS resolver hooks, display results in the console (WIP) Jul 13, 2022

removed non MUI components, added search spinner on search

46e0d4a

Seroxdesign changed the title ~~added ENS resolver hooks, display results in the console (WIP)~~ added ENS resolver hooks, display results in the console (Ready for review) Jul 14, 2022

vercel bot deployed to Preview July 18, 2022 11:54 View deployment

vmichalik self-requested a review July 18, 2022 16:46

vmichalik approved these changes Jul 18, 2022

View reviewed changes

elvijsTDL requested changes Jul 18, 2022

View reviewed changes

fixed Address sizing and format on account page, removed text when se…

fa93e61

…arching for an address in addressbook

fixed spinner by using the isFetching flag on ENSquery

09bf017

vercel bot deployed to Preview August 18, 2022 17:07 View deployment

Use only Superfluid RPC for ENS

c28389b

vercel bot deployed to Preview August 18, 2022 17:15 View deployment

elvijsTDL approved these changes Aug 19, 2022

View reviewed changes

Clean up

73968f6

* rename to clarify intent * be more explicit with types * remove unneccessary try-catches

kasparkallas approved these changes Aug 19, 2022

View reviewed changes

vercel bot deployed to Preview August 19, 2022 09:23 View deployment

kasparkallas added 2 commits August 19, 2022 12:48

Fix search term being showed as the address display name

777e0a4

Add more address formatting options

1437da0

vercel bot deployed to Preview August 19, 2022 11:50 View deployment

kasparkallas mentioned this pull request Aug 19, 2022

feat(console): add ens domains #88

Closed

kasparkallas merged commit 6402c0a into superfluid-finance:master Aug 19, 2022

kasparkallas mentioned this pull request Sep 20, 2022

[CONSOLE] ENS Support #58

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added ENS resolver hooks, display results in the console (Ready for review) #105

added ENS resolver hooks, display results in the console (Ready for review) #105

Seroxdesign commented Jul 4, 2022 •

edited

Loading

vercel bot commented Jul 4, 2022

Seroxdesign commented Jul 4, 2022 •

edited

Loading

kasparkallas commented Jul 5, 2022 •

edited

Loading

Seroxdesign commented Jul 5, 2022

Seroxdesign commented Jul 6, 2022

Seroxdesign commented Jul 7, 2022

vercel bot commented Jul 12, 2022 •

edited

Loading

kasparkallas left a comment •

edited

Loading

Seroxdesign commented Jul 12, 2022

Seroxdesign commented Jul 12, 2022

Seroxdesign commented Jul 13, 2022

vmichalik left a comment

elvijsTDL commented Jul 18, 2022 •

edited

Loading

elvijsTDL left a comment •

edited

Loading

Seroxdesign commented Jul 18, 2022

Seroxdesign commented Jul 20, 2022

Seroxdesign commented Jul 20, 2022

Seroxdesign commented Jul 20, 2022 •

edited

Loading

Seroxdesign commented Jul 23, 2022 •

edited

Loading

Seroxdesign commented Jul 26, 2022

vmichalik commented Jul 27, 2022

elvijsTDL commented Aug 19, 2022

kasparkallas left a comment •

edited

Loading

added ENS resolver hooks, display results in the console (Ready for review) #105

added ENS resolver hooks, display results in the console (Ready for review) #105

Conversation

Seroxdesign commented Jul 4, 2022 • edited Loading

Progress

Remaining work

vercel bot commented Jul 4, 2022

Seroxdesign commented Jul 4, 2022 • edited Loading

ready for review

kasparkallas commented Jul 5, 2022 • edited Loading

Seroxdesign commented Jul 5, 2022

Seroxdesign commented Jul 6, 2022

Seroxdesign commented Jul 7, 2022

vercel bot commented Jul 12, 2022 • edited Loading

kasparkallas left a comment • edited Loading

Choose a reason for hiding this comment

Seroxdesign commented Jul 12, 2022

Seroxdesign commented Jul 12, 2022

Seroxdesign commented Jul 13, 2022

vmichalik left a comment

Choose a reason for hiding this comment

elvijsTDL commented Jul 18, 2022 • edited Loading

elvijsTDL left a comment • edited Loading

Choose a reason for hiding this comment

Seroxdesign commented Jul 18, 2022

Seroxdesign commented Jul 20, 2022

Seroxdesign commented Jul 20, 2022

Seroxdesign commented Jul 20, 2022 • edited Loading

Seroxdesign commented Jul 23, 2022 • edited Loading

Seroxdesign commented Jul 26, 2022

vmichalik commented Jul 27, 2022

elvijsTDL commented Aug 19, 2022

kasparkallas left a comment • edited Loading

Choose a reason for hiding this comment

Seroxdesign commented Jul 4, 2022 •

edited

Loading

Seroxdesign commented Jul 4, 2022 •

edited

Loading

kasparkallas commented Jul 5, 2022 •

edited

Loading

vercel bot commented Jul 12, 2022 •

edited

Loading

kasparkallas left a comment •

edited

Loading

elvijsTDL commented Jul 18, 2022 •

edited

Loading

elvijsTDL left a comment •

edited

Loading

Seroxdesign commented Jul 20, 2022 •

edited

Loading

Seroxdesign commented Jul 23, 2022 •

edited

Loading

kasparkallas left a comment •

edited

Loading