GDA mappings #190
GDA mappings #190
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Cypress Tests tests failed after 10m 27s Run Details
Failed Spec Files
This message was posted automatically by
currents.dev | Integration Settings
|
kasparkallas
requested review from
Mikkoun,
kasparkallas,
tokdaniel and
elvijsTDL
There was a problem hiding this comment.
1) The members table should be renamed IMO and tooltip changed up abit more to explain that it shows the tables the account is connected to, this tooltip seems like it belongs to the pool details page
https://github.com/superfluid-finance/superfluid-console/assets/77115130/3e9c2591-aae8-4e7c-b05e-1c95e63f809b
2) Typo:
https://github.com/superfluid-finance/superfluid-console/assets/77115130/6a219fd9-73d5-4cff-854c-bfde0f77da19
3) No blockchain explorer button in the pool details page
https://github.com/superfluid-finance/superfluid-console/assets/77115130/8fc41f1f-1caa-48fa-a939-9ac2df1e5a42
Pool details page does not show flow and instant distributions altho the totals are shown correctly? https://superfluid-console-git-gdamapping-superfluid-finance.vercel.app/avalanche-fuji/pools/0x9a4a1d83be575f3ec59ff259d65d6fe94f78a3d8
https://github.com/superfluid-finance/superfluid-console/assets/77115130/f762cd2a-8da4-46a4-8f3b-f5d0b79dc914
4) If there is no data about the pools it should show "No rows" like the other tables in the console
https://github.com/superfluid-finance/superfluid-console/assets/77115130/2ba47597-c6e0-41bb-9302-45156084c19e
5) Lets stick to one - "approved" or "connected" to be less confusing, also the values between the table in pool details page and member details page is different,that does not seem right
https://github.com/superfluid-finance/superfluid-console/assets/77115130/028842c2-7fc2-4bb3-b587-df1e7e7ab971t
- In the account page the pools tables do not refresh if user searches for a new address , try this address to check https://superfluid-console-git-gdamapping-superfluid-finance.vercel.app/avalanche-fuji/accounts/0xc19be11b5f9eac59758f4dbaaad465abb9103a95?tab=streams
Screen.Recording.2023-11-14.at.15.30.00.mov
8) The member data does not seem correct, .e.g in the pool details table I can see the account has received some distributions, but there is no data of the member anywhere shown here https://superfluid-console-git-gdamapping-superfluid-finance.vercel.app/avalanche-fuji/pool-subscriptions/poolMember-0x9a4a1d83be575f3ec59ff259d65d6fe94f78a3d8-0xc19be11b5f9eac59758f4dbaaad465abb9103a95
9) Adjustment flow rates in the pool pages are all just 0s
https://github.com/superfluid-finance/superfluid-console/assets/77115130/edac532b-5a46-4674-abbe-b3629e22af80t
10) The token amounts for instant distributions are not formatted ( should be divided by the decimal amount ) and are not correctly calculated
11) The pool member total claimed amount is wrong
|
Closing this pull request because the same commits will be included in the other pull request: #198 |
No description provided.