-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Governance params and super tokens page #64
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superfluid-finance/superfluid-console/Gbu6UcUD8y2vj5a5183WQiWq99Fd |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/redux/protocolContracts.ts
Outdated
superTokenFactory: "0xA25dbEa94C5824892006b30a629213E7Bf238624", | ||
superfluidLoaderv1: "0x777Be25F9fdcA87e8a0E06Ad4be93d65429FCb9f", | ||
}, | ||
} as NetworkContracts; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In places like this, I'd rather do: const protocolContracts: NetworkContracts = { ...
Looks excellent overall, really cool and will bring in way more people to using the console!
future observations:
|
|
For testnets its 12 minutes and 1 hour so that would be 1/5th |
I wouldn't add default sorting to super tokens table because we can only order by one field at a time and if we ordered by name then all the first tokens would be without name - basically it would not look good. |
Tooltips are still being reviewed by Nuno.