Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance params and super tokens page #64

Merged
merged 10 commits into from
Apr 22, 2022
Merged

Conversation

Mikkoun
Copy link
Contributor

@Mikkoun Mikkoun commented Apr 14, 2022

Tooltips are still being reviewed by Nuno.

@vercel
Copy link

vercel bot commented Apr 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superfluid-finance/superfluid-console/Gbu6UcUD8y2vj5a5183WQiWq99Fd
✅ Preview: https://superfluid-console-git-governance-page-superfluid-finance.vercel.app

@Mikkoun Mikkoun changed the title Governance page Governance params and super tokens page Apr 14, 2022
@vercel
Copy link

vercel bot commented Apr 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
superfluid-console ✅ Ready (Inspect) Visit Preview Apr 22, 2022 at 7:59AM (UTC)

superTokenFactory: "0xA25dbEa94C5824892006b30a629213E7Bf238624",
superfluidLoaderv1: "0x777Be25F9fdcA87e8a0E06Ad4be93d65429FCb9f",
},
} as NetworkContracts;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In places like this, I'd rather do: const protocolContracts: NetworkContracts = { ...

@vmichalik
Copy link
Contributor

Looks excellent overall, really cool and will bring in way more people to using the console!
Few ideas:

  • hover states seem to be missing, especially for the top right links
  • sort options for token table
  • default sort on tokens by isListed, then by alphabetical
  • tooltip on listed in super tokens table
  • scanner links next to copy icons in protocol governance addresses

future observations:

  • we'll need a better way of showing network names to select rather than the scrollable bar when we add the next few

@elvijsTDL
Copy link
Contributor

elvijsTDL commented Apr 19, 2022

The splitting lines between rows we have everywhere else would also be nice in the governance page
Screenshot 2022-04-19 at 12 37 20

Screenshot 2022-04-19 at 12 37 41

Also, why did we lose the green Subgraph explorer button?
Screenshot 2022-04-19 at 13 04 06

@vmichalik
Copy link
Contributor

  • also, patrician period is defined as 1/8 of the total period, not as 30min
    this is generally not relevant, but it can be in certain cases

@elvijsTDL
Copy link
Contributor

  • also, patrician period is defined as 1/8 of the total period, not as 30min
    this is generally not relevant, but it can be in certain cases

For testnets its 12 minutes and 1 hour so that would be 1/5th

@Mikkoun
Copy link
Contributor Author

Mikkoun commented Apr 21, 2022

  • Super tokens can not be ordered by name and listed status.
  • Added tooltip for listed field
  • Some other minor UI fixes

I wouldn't add default sorting to super tokens table because we can only order by one field at a time and if we ordered by name then all the first tokens would be without name - basically it would not look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants