Graceful HTTP server shutdown #52

jeromegn · 2019-01-28T21:33:51Z

This fixes #51

Intercepts SIGINT and SIGTERM
Tells the hyper server to gracefully stop (waits for current requests to finish, closes connections)
Disposes of each runtime currently running (eventually we could have an event in JS like "dispose")
Unifies both the non-TLS server and TLS server as just a stream of connections
Small fixups everywhere (rust 2018, small changes)

…ing on the main event loop)

michaeldwan · 2019-01-29T15:23:50Z

distributed-fly/src/main.rs

+            match sigrelaytx.send(()) {
+                Ok(_) => {}
+                Err(_) => {}
+            }; // don't care about result, do care about compiler warning...


I think you can use the ok() function on Result to ignore

jeromegn added 3 commits January 28, 2019 16:21

gracefully shutdown http server (+ runtime selector and anything runn…

04e2eef

…ing on the main event loop)

fix warning, remove unecessary box

d97ee9b

Merge branch 'master' into graceful-shutdown

c0b4bd8

michaeldwan approved these changes Jan 29, 2019

View reviewed changes

michaeldwan merged commit c1c7ff6 into master Jan 29, 2019

michaeldwan deleted the graceful-shutdown branch January 29, 2019 15:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Graceful HTTP server shutdown #52

Graceful HTTP server shutdown #52

jeromegn commented Jan 28, 2019

michaeldwan Jan 29, 2019

jeromegn Jan 29, 2019

Graceful HTTP server shutdown #52

Graceful HTTP server shutdown #52

Conversation

jeromegn commented Jan 28, 2019

michaeldwan Jan 29, 2019

Choose a reason for hiding this comment

jeromegn Jan 29, 2019

Choose a reason for hiding this comment