Skip to content

Commit

Permalink
Don't mount volumes to releaseCommandMachine
Browse files Browse the repository at this point in the history
From my understanding after reading the code, lalunchInput is just the machine used for the release command.
We aren't supposed to mount volumes to them anyway, so this should be fine.
Should fix #1752
  • Loading branch information
billyb2 committed Feb 24, 2023
1 parent a3afbfc commit 27cbfc7
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions internal/command/deploy/machines.go
Original file line number Diff line number Diff line change
Expand Up @@ -624,11 +624,6 @@ func (md *machineDeployment) resolveUpdatedMachineConfig(origMachineRaw *api.Mac

if origMachineRaw.Config.Mounts != nil {
launchInput.Config.Mounts = origMachineRaw.Config.Mounts
} else if md.appConfig.Mounts != nil {
launchInput.Config.Mounts = []api.MachineMount{{
Path: md.volumeDestination,
Volume: md.volumes[0].ID,
}}
}

if len(launchInput.Config.Mounts) == 1 && launchInput.Config.Mounts[0].Path != md.volumeDestination {
Expand Down

0 comments on commit 27cbfc7

Please sign in to comment.