Enable node framework applications to create a volume

internal/command/launch/srcinfo.go

@@ -326,8 +326,22 @@ func runCallback(ctx context.Context, srcInfo *scanner.SourceInfo, options map[s
 			cfg, err := appconfig.LoadConfig(srcInfo.MergeConfig.Name)
 			if err == nil {
 				// In theory, any part of the configuration could be merged here, but for now
-				// we will only copy over the processes
-				srcInfo.Processes = cfg.Processes
+				// we will only copy over the processes and volume
+				if srcInfo.Processes == nil {
+					srcInfo.Processes = cfg.Processes
+				}
+
+				if len(srcInfo.Volumes) == 0 && len(cfg.Mounts) > 0 {
+					volume := scanner.Volume{
+						Source:      cfg.Mounts[0].Source,
+						Destination: cfg.Mounts[0].Destination,
+						// TODO: shouldn't srcInfo.Volumes and appConfig.Mounts be reconciled?
+						//       * ideally they should be the same type
+						//       * failing that, Volume should include Processes []string
+					}
+
+					srcInfo.Volumes = []scanner.Volume{volume}
+				}
 			}
 		}
 

scanner/nodeFramework.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"fmt"
 	"io/fs"
+	"log"
 	"os"
 	"os/exec"
 	"regexp"
@@ -73,6 +74,23 @@ func configureNodeFramework(sourceDir string, config *ScannerConfig) (*SourceInf
 		Callback:   NodeFrameworkCallback,
 	}
 
+	flyToml := "fly.toml"
+	_, err = os.Stat(flyToml)
+	if os.IsNotExist(err) {
+		// "touch" fly.toml
+		file, err := os.Create(flyToml)
+		if err != nil {
+			log.Fatal(err)
+		}
+		file.Close()
+
+		// inform caller of the presence of this file
+		srcInfo.MergeConfig = &MergeConfigStruct{
+			Name:      flyToml,
+			Temporary: true,
+		}
+	}
+
 	return srcInfo, nil
 }
 
@@ -116,6 +134,7 @@ func NodeFrameworkCallback(srcInfo *SourceInfo, options map[string]bool) error {
 
 		// install/run command
 		if !installed || args[0] == "npx" {
+			fmt.Printf("installing: %s\n", strings.Join(args[:], " "))
 			cmd := exec.Command(args[0], args[1:]...)
 			cmd.Stdin = nil
 			cmd.Stdout = os.Stdout

scanner/rails.go

@@ -133,15 +133,15 @@ func RailsCallback(srcInfo *SourceInfo, options map[string]bool) error {
 		_, err := os.Stat(flyToml)
 		if os.IsNotExist(err) {
 			// "touch" fly.toml
-			file, err := os.Create("fly.toml")
+			file, err := os.Create(flyToml)
 			if err != nil {
 				log.Fatal(err)
 			}
 			file.Close()
 
 			// inform caller of the presence of this file
 			srcInfo.MergeConfig = &MergeConfigStruct{
-				Name:      "fly.toml",
+				Name:      flyToml,
 				Temporary: true,
 			}
 		}