Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

machines: clone breaks for non-postgres apps #1305

Merged
merged 2 commits into from Sep 27, 2022
Merged

machines: clone breaks for non-postgres apps #1305

merged 2 commits into from Sep 27, 2022

Conversation

ignoramous
Copy link
Contributor

More: https://community.fly.io/t/7265

Exec:

➜  flyctl ✗ go build -o fly2

➜  flyctl ✗ go test
?   	github.com/superfly/flyctl	[no test files]

➜ fly2 m clone d5683061b4158e --config fly.machines.toml --name udns-gru2 --region gru
Cloning machine in region gru for app udns
Machine d5683061b4158e was cloned to 73287111be1385

davissp14
davissp14 requested changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@davissp14 davissp14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Thank you! Just looking for some context on the TryWait addition.

flaps/flaps.go Outdated Show resolved Hide resolved
internal/command/machine/clone.go Show resolved Hide resolved
davissp14
davissp14 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@davissp14 davissp14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@davissp14 davissp14 merged commit 03233b7 into superfly:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davissp14 davissp14 davissp14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ignoramous @davissp14