Restart rework #1457
Merged
Restart rework #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsierles
approved these changes
Nov 15, 2022
internal/command/apps/restart.go
Outdated
| ) | ||
|
|
||
| func newRestart() *cobra.Command { | ||
| const ( | ||
| long = `The APPS RESTART command will restart all running vms. | ||
| ` | ||
| long = `The APPS RESTART command will perform a rolling restart against all running VM's` |
| NewOpen(), | ||
| NewReleases(), | ||
| ) | ||
|
|
||
| return apps | ||
| } | ||
|
|
||
| // BuildContext is a helper that builds out commonly required context requirements | ||
| func BuildContext(ctx context.Context, app *api.AppCompact) (context.Context, error) { |
There was a problem hiding this comment.
Is this mainly to get the flaps client into context?
There was a problem hiding this comment.
Both the flaps client and dialer.
| @@ -0,0 +1,52 @@ | |||
| package machine | |||
There was a problem hiding this comment.
Is it a problem that we have the machines package split across internal/command/machine and internal/machine?
There was a problem hiding this comment.
We can rename the package if it's confusing, but it's not really an issue afaict. If both packages need to be used at the same time we will just need to define an alias during import.
shortdiv
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
fly apps restart now supports Machines.
Machine orchestration primitives have been abstracted out into a higher level
machinespackage. This will allow us to easily re-use them across command packages.https://github.com/superfly/flyctl/tree/fly-restart-rework-2/internal/machine
fly restart
This command is being softly removed. A user will receive an error indicating that they should use
fly apps restartinstead.fly apps restart
This is what almost all apps should be using.
Unfortunately, I was not able to include the PG restart process due to a cyclic dependency issue. The postgres package will need to be restructured a bit before we can make this work. PG apps will receive an error when hitting this command indicating they should use
fly pg restartinstead. Not great, but progress.fly pg restart
Has been reworked to use the new machine orchestration primitives.
fly machine restart
Has been reworked to use the new machine orchestration primitives.